Check Spotless formatting by default build #45
Closed
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slachiewicz
approved these changes
Mar 14, 2025
slachiewicz
approved these changes
Mar 14, 2025
slawekjaranowski
requested changes
Mar 14, 2025
|
If it was active by default, the GH action builds of the mentioned projects should have failed, right? Should I change the PR to set this environment variable or perhaps to activate the Maven profile? |
|
So to rephrase, yes it should be done on parent in similar way that we have in maven parent pom for apache org, where we agreed that always format code, not only check. |
4728227 to
0e3e406
Compare
Detected in the course of support-and-care/maven-support-and-care#77.
0e3e406 to
2381261
Compare
|
I switched to setting the CI environment variable. |
Comment on lines
+77
to
+79
| env: | ||
| CI: true | ||
|
|
There was a problem hiding this comment.
it is a default value ... should not be overridden
ascheman
added a commit
to support-and-care/plexus-pom
that referenced
this pull request
Apr 8, 2025
Builds should either apply spotless or check for it depending on whether it is running in CI or not. Detected in the course of support-and-care/maven-support-and-care#77 and codehaus-plexus/.github#45
|
Replaced by codehaus-plexus/plexus-pom#344 |
slachiewicz
pushed a commit
to codehaus-plexus/plexus-pom
that referenced
this pull request
Apr 8, 2025
Builds should either apply spotless or check for it depending on whether it is running in CI or not. Detected in the course of support-and-care/maven-support-and-care#77 and codehaus-plexus/.github#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected in the course of support-and-care/maven-support-and-care#77.
This PR should not be merged before