Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update build, get rid of legacy, fix CLI #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Update build, get rid of legacy, fix CLI #452

merged 4 commits into from
Jun 5, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 29, 2024

Fixes #434

@cstamas cstamas requested a review from slawekjaranowski May 29, 2024 17:10
@cstamas cstamas self-assigned this May 29, 2024
@cstamas cstamas marked this pull request as ready for review May 29, 2024 17:17
@cstamas
Copy link
Member Author

cstamas commented May 29, 2024

Not yet done: need to review (and probably) fix the modello-maven-plugin deps, as they are off now done

@fridrich
Copy link

I would still prefer 90352d3 because there are tools out there that instantiate the Modello class. And also lookup of ModeloCore.ROLE is done all around the place in tests, so this would be consistent with that.

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

@fridrich ported, pls review

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

The lookup does not matter, the String ROLE is legacy, latest Plexus (not the sisu plexus shim) introduced lookup(Class) and the only difference is that you don't need casting.

@fridrich
Copy link

Another thing. the slf4j-simple does not need to be runtime dependency. one can have there slf4j-nop if one does not need logging

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

Without slf4j backend, CLI will emit warning like you reported in the issue... So you say that no logging backend is needed at all? (noop?)

@fridrich
Copy link

The slf4j-nop is an artifact that is noop logger

@fridrich
Copy link

org.slf4j:slf4j-nop is the artifact

@fridrich
Copy link

So, one can leave the choice for the user.

@fridrich
Copy link

testing, will report in 30 minutes

@fridrich
Copy link

Faster then that: it works. Thanks a lot.

@fridrich
Copy link

nagyom szepem keszenem

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

ni za kaj (molim, i drugi put)

@fridrich
Copy link

ni za kaj (molim, i drugi put)

In my original language it would be: "nemas za co (dakujem a aj druhy raz)"

@fridrich
Copy link

Just there is a downgrade of plexus-utils 4.0.1 -> 3.5.1 Intended?

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

Just there is a downgrade of plexus-utils 4.0.1 -> 3.5.1 Intended?

Yes, keep this Maven3 compat for now (p-u 3.x is for Maven3, p-u 4.x is for Maven4)

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

Let's see what @slawekjaranowski has to say as well...

@cstamas
Copy link
Member Author

cstamas commented Jun 4, 2024

@slawekjaranowski ping

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some magics with dependencies but ok πŸ˜„

@cstamas
Copy link
Member Author

cstamas commented Jun 5, 2024

Reason for magic: we make modello-core "complete" as it provides now (and was providing) the CLI that needs to be runnable. And then later, in modello-maven-plugin we make sure that bits provided to maven plugins are properly provided/excluded. Before, it was "provided" in modello-core, so nothing was needed in modello-maven-plugin, but this breaks CLI. Now, modello-core is "complete" and modello-maven-plugin POM makes sure all is okay in plugin as well.

@cstamas cstamas merged commit 0c1a562 into master Jun 5, 2024
12 checks passed
@cstamas cstamas deleted the update-fix-cli branch June 5, 2024 08:16
@fridrich
Copy link

fridrich commented Jun 7, 2024

Would a working CLI justify a 2.4.1? @slawekjaranowski @cstamas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelloCli is not working in 2.3.0
3 participants