Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: disableProcessTimeout in analyze script#7715

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
ddevsr:patch-1
Jul 24, 2023
Merged

chore: disableProcessTimeout in analyze script#7715
samsonasik merged 1 commit into
codeigniter4:developfrom
ddevsr:patch-1

Conversation

@ddevsr

@ddevsr ddevsr commented Jul 19, 2023

Copy link
Copy Markdown
Collaborator

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan changed the title chore: disableProcessTimeout in analyze Composer chore: disableProcessTimeout in analyze script Jul 19, 2023
@paulbalandan

Copy link
Copy Markdown
Member

Where does it timeout? phpstan or rector?

@MGatner

MGatner commented Jul 23, 2023

Copy link
Copy Markdown
Member

It's what we recommend in DevKit. I always add it myself, not sure if it has ever prevented a timeout or not though.

@kenjis kenjis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my environment, Rector times out.

@kenjis

kenjis commented Jul 24, 2023

Copy link
Copy Markdown
Member

@ddevsr

ddevsr commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator Author

@ddevsr Can you also update https://github.com/codeigniter4/devkit/blob/edf1036c56ee09b322261f0bc9eae9dc4f5fffa8/composer.json#L51 ?

@kenjis Done

@samsonasik samsonasik merged commit fc4387f into codeigniter4:develop Jul 24, 2023
@samsonasik

Copy link
Copy Markdown
Member

Thank you @ddevsr

@ddevsr ddevsr deleted the patch-1 branch July 24, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants