Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add enum casting #9752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2025
Merged

feat: add enum casting #9752

merged 3 commits into from
Oct 10, 2025

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Oct 9, 2025

Description
This PR adds enum casting for model and entity.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
feat: support casting values to enums
078fa0c 
fix phpstan errors

more validation and testing

feat: support casting values to enums
@michalsn michalsn added enhancement PRs that improve existing functionalities 4.7 labels Oct 9, 2025
neznaika0
neznaika0 suggested changes Oct 9, 2025
View reviewed changes
neznaika0
neznaika0 approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @michalsn. I'll use it in the project when I have time.

paulbalandan
paulbalandan reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

lonnieezell
lonnieezell approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Very solid implementation.

@michalsn michalsn merged commit 37ff9fa into codeigniter4:4.7 Oct 10, 2025
50 checks passed
@michalsn
Copy link
Member Author

Thanks everyone for the review!

@michalsn michalsn deleted the feat/enum-cast branch October 10, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4.7 enhancement PRs that improve existing functionalities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalsn @lonnieezell @neznaika0 @paulbalandan