fix: only disable parallel tool use when tools are injected #96
Conversation
This change adds an early return in injectTools() when there are no tools to inject from MCP, preventing unnecessary modification of the tool_choice parameter. Previously, disable_parallel_tool_use was set even when no tools were injected, which was incorrect behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ssncferreira
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments 🍰
| // Tools are still injected. | ||
| require.Len(t, i.req.Tools, 1) |
There was a problem hiding this comment.
Not sure I fully understand this case. The AI client sends a request with tool_choice: none, telling Anthropic to not execute any tools. But AIBridge still injects the tools even though Anthropic will never execute them, right?
There was a problem hiding this comment.
Good question! We don't conditionally inject tools based on tool choice right now. Maybe we should...
I'm in favour of not trying to be too clever / efficient here because this behaviour might confuse us / an operator looking at request logs. It might not be immediately apparently that tools didn't inject for this reason.
This change adds an early return in injectTools() when there are no
tools to inject from MCP, preventing unnecessary modification of the
tool_choice parameter. Previously, disable_parallel_tool_use was set
even when no tools were injected, which was incorrect behaviour.