filling out started_at when unhanging not started jobs

ibetitsmike · ibetitsmike · commit 0b914a3ee68c · 2025-05-09T13:56:08.000Z
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/provisionerjobs.sql b/coderd/database/queries/provisionerjobs.sql
@@ -252,7 +252,8 @@ SET
 	updated_at = $2,
 	completed_at = $3,
 	error = $4,
-	error_code = $5
+	error_code = $5,
+	started_at = $6
 WHERE
 	id = $1;
 
diff --git a/coderd/unhanger/detector.go b/coderd/unhanger/detector.go
@@ -287,11 +287,21 @@ func unhangJob(ctx context.Context, log slog.Logger, db database.Store, pub pubs
 		}
 		lowestLogID = newLogs[0].ID
 
-		// Mark the job as failed.
 		now = dbtime.Now()
+		// If we are unhanging a job that was never picked up by the
+		// provisioner, we need to set the started_at time to the current
+		// time so that the build duration is correct.
+		if !job.StartedAt.Valid {
+			job.StartedAt = sql.NullTime{
+				Time:  now,
+				Valid: true,
+			}
+		}
+		// Mark the job as failed.
 		err = db.UpdateProvisionerJobWithCompleteByID(ctx, database.UpdateProvisionerJobWithCompleteByIDParams{
 			ID:        job.ID,
 			UpdatedAt: now,
+			StartedAt: job.StartedAt,
 			CompletedAt: sql.NullTime{
 				Time:  now,
 				Valid: true,
