ci: Fix release workflow env vars

mafredri · mafredri · commit 182fc6de53bc · 2023-01-12T12:22:56.000Z
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -39,11 +39,20 @@ permissions:
   # Necessary for GCP authentication (https://github.com/google-github-actions/setup-gcloud#usage)
   id-token: write
 
-env:
-  CODER_RELEASE: ${{ !github.event.inputs.snapshot }}
-
 concurrency: ${{ github.workflow }}-${{ github.ref }}
 
+env:
+  # Use string semantics for negating the boolean, otherwise it will always
+  # be false. See https://github.com/actions/runner/issues/1483.
+  # Note that any time we need to do expressions, more than outputting the
+  # actual boolean value, it's safest to use `contains` because it casts the
+  # input to string, meaning we get the same behavior for true and 'true'.
+  # Boolean behavior differs between workflow_dispatch and workflow_call.
+  CODER_RELEASE: ${{ contains(github.event.inputs.snapshot, 'false') }}
+  CODER_RELEASE_INCREMENT: ${{ github.event.inputs.increment }}
+  CODER_RELEASE_DRAFT: ${{ github.event.inputs.draft }}
+  CODER_DRY_RUN: ${{ contains(github.event.inputs.dry_run, 'true') || contains(github.event.inputs.snapshot, 'true') }}
+
 jobs:
   release:
     name: Create and publish
@@ -87,7 +96,7 @@ jobs:
           fi
 
           version_args=()
-          if [[ "${{ github.event.inputs.dry_run || github.event.inputs.snapshot }}" == *t* ]]; then
+          if [[ $CODER_DRY_RUN == *t* ]]; then
             # Allow dry-run of branches to pass.
             export CODER_IGNORE_MISSING_COMMIT_METADATA=1
             version_args+=(--dry-run)
@@ -104,7 +113,7 @@ jobs:
             ./scripts/release/tag_version.sh \
               "${version_args[@]}" \
               --ref "$ref" \
-              --${{ github.event.inputs.increment }}
+              --"$CODER_RELEASE_INCREMENT"
           )"
 
           # Generate notes.
@@ -232,10 +241,10 @@ jobs:
           set -euo pipefail
 
           publish_args=()
-          if [[ "${{ github.event.inputs.draft }}" == *t* ]]; then
+          if [[ $CODER_RELEASE_DRAFT == *t* ]]; then
             publish_args+=(--draft)
           fi
-          if [[ "${{ github.event.inputs.dry_run || github.event.inputs.snapshot }}" == *t* ]]; then
+          if [[ $CODER_DRY_RUN == *t* ]]; then
             publish_args+=(--dry-run)
           fi
           declare -p publish_args
@@ -263,7 +272,8 @@ jobs:
         uses: "google-github-actions/setup-gcloud@v1"
 
       - name: Publish Helm Chart
-        if: ${{ !github.event.inputs.dry_run && !github.event.inputs.snapshot }}
+        # Do not publish helm charts for either dry run or snapshots.
+        if: ${{ contains(github.event.inputs.dry_run, 'false') && contains(github.event.inputs.snapshot, 'false') }}
         run: |
           set -euo pipefail
           version="$(./scripts/version.sh)"
@@ -275,7 +285,7 @@ jobs:
           gsutil -h "Cache-Control:no-cache,max-age=0" cp build/helm/index.yaml gs://helm.coder.com/v2
 
       - name: Upload artifacts to actions (if dry-run or snapshot)
-        if: ${{ github.event.inputs.dry_run || github.event.inputs.snapshot }}
+        if: ${{ contains(github.event.inputs.dry_run, 'true') || contains(github.event.inputs.snapshot, 'true') }}
         uses: actions/upload-artifact@v2
         with:
           name: release-artifacts
diff --git a/scripts/release.sh b/scripts/release.sh
@@ -167,9 +167,11 @@ else
 fi
 
 log
-gh workflow run release.yaml \
+# Use maybedryrun to echo the command.
+maybedryrun 0 gh workflow run release.yaml \
 	--ref "$branch" \
 	-F increment="$increment" \
+	-F snapshot=false \
 	"${args[@]}"
 log
 
