fix: updates for PR review

jaaydenh · jaaydenh · commit 19767201dc94 · 2025-04-15T15:26:37.000Z
diff --git a/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx b/site/src/components/MultiSelectCombobox/MultiSelectCombobox.tsx
@@ -205,15 +205,13 @@ export const MultiSelectCombobox = forwardRef<
 		const [isLoading, setIsLoading] = useState(false);
 		const dropdownRef = useRef<HTMLDivElement>(null);
 
-		const getInitialSelectedOptions = () => {
-			if (arrayDefaultOptions && arrayDefaultOptions.length > 0) {
-				return arrayDefaultOptions;
-			}
-			return [];
-		};
-
 		const [selected, setSelected] = useState<Option[]>(
-			getInitialSelectedOptions,
+			() => {
+				if (arrayDefaultOptions && arrayDefaultOptions.length > 0) {
+					return arrayDefaultOptions;
+				}
+				return [];
+			}
 		);
 		const [options, setOptions] = useState<GroupOption>(
 			transitionToGroupOption(arrayDefaultOptions, groupBy),
diff --git a/site/src/hooks/useWebsocket.ts b/site/src/hooks/useWebsocket.ts
@@ -21,15 +21,13 @@ export function useWebSocket<T>(
 			setConnectionStatus("connecting");
 
 			ws.onopen = () => {
-				// console.log("Connected to WebSocket");
 				setConnectionStatus("connected");
 				ws.send(JSON.stringify({}));
 			};
 
 			ws.onmessage = (event) => {
 				try {
 					const data: T = JSON.parse(event.data);
-					// console.log("Received message:", data);
 					setMessage(data);
 				} catch (err) {
 					console.error("Invalid JSON from server: ", event.data);
@@ -42,9 +40,6 @@ export function useWebSocket<T>(
 			};
 
 			ws.onclose = (event) => {
-				// console.log(
-				// 	`WebSocket closed with code ${event.code}. Reason: ${event.reason}`,
-				// );
 				setConnectionStatus("disconnected");
 			};
 		} catch (error) {
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -209,7 +209,7 @@ export const CreateWorkspacePageViewExperimental: FC<
 		parameters,
 	]);
 
-	const [debouncedTimer, setDebouncedTimer] = useState<NodeJS.Timeout | null>(
+	const [debouncedTimer, setDebouncedTimer] = useState<ReturnType<typeof setTimeout> | null>(
 		null,
 	);
 
@@ -226,15 +226,9 @@ export const CreateWorkspacePageViewExperimental: FC<
 
 		// Create the request object
 		const createRequest = () => {
-			// Convert the rich_parameter_values array to a key-value object
-			const newInputs = (form.values.rich_parameter_values ?? []).reduce(
-				(acc, param) => {
-					acc[param.name] = param.value;
-					return acc;
-				},
-				{} as Record<string, string>,
-			);
-
+			const newInputs = Object.fromEntries(form.values.rich_parameter_values?.map(value => {
+				return [value.name, value.value]
+			}) ?? []);
 			// Update the input for the changed parameter
 			newInputs[parameter.name] = value;
 
@@ -274,7 +268,6 @@ export const CreateWorkspacePageViewExperimental: FC<
 		};
 	}, [debouncedTimer]);
 
-	// TODO: display top level diagnostics
 	return (
 		<>
 			<div className="absolute sticky top-5 ml-10">
@@ -458,22 +451,16 @@ export const CreateWorkspacePageViewExperimental: FC<
 												selectedOption={presetOptions[selectedPresetIndex]}
 											/>
 										</div>
-										<div
-											css={{
-												display: "flex",
-												alignItems: "center",
-												gap: "8px",
-											}}
-										>
+										<span className="flex items-center gap-3">
 											<Switch
 												id="show-preset-parameters"
 												checked={showPresetParameters}
 												onCheckedChange={setShowPresetParameters}
 											/>
-											<label htmlFor="show-preset-parameters">
+											<Label htmlFor="show-preset-parameters">
 												Show preset parameters
-											</label>
-										</div>
+											</Label>
+										</span>
 									</div>
 								</Stack>
 							)}
@@ -508,7 +495,6 @@ export const CreateWorkspacePageViewExperimental: FC<
 											}
 											disabled={isDisabled}
 											isPreset={isPresetParameter}
-											// parameterAutofill={autofillByName[parameter.name]} TODO: handle autofill
 										/>
 									);
 								})}
