feat(testutil): add GetRandomNameHyphenated (#17342)

johnstcn · Copilot · web-flow · commit 1e0051a9a27d · 2025-04-10T19:08:38.000+01:00
This started coming up more often for me, so time for a test helper!

---------

Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/cli/templatepush_test.go b/cli/templatepush_test.go
@@ -534,7 +534,7 @@ func TestTemplatePush(t *testing.T) {
 						"test_name": tt.name,
 					}))
 
-					templateName := strings.ReplaceAll(testutil.GetRandomName(t), "_", "-")
+					templateName := testutil.GetRandomNameHyphenated(t)
 
 					inv, root := clitest.New(t, "templates", "push", templateName, "-d", tempDir, "--yes")
 					clitest.SetupConfig(t, templateAdmin, root)
diff --git a/coderd/templateversions_test.go b/coderd/templateversions_test.go
@@ -617,7 +617,7 @@ func TestPostTemplateVersionsByOrganization(t *testing.T) {
 				require.NoError(t, err)
 
 				// Create a template version from the archive
-				tvName := strings.ReplaceAll(testutil.GetRandomName(t), "_", "-")
+				tvName := testutil.GetRandomNameHyphenated(t)
 				tv, err := templateAdmin.CreateTemplateVersion(ctx, owner.OrganizationID, codersdk.CreateTemplateVersionRequest{
 					Name:            tvName,
 					StorageMethod:   codersdk.ProvisionerStorageMethodFile,
diff --git a/testutil/names.go b/testutil/names.go
@@ -2,6 +2,7 @@ package testutil
 
 import (
 	"strconv"
+	"strings"
 	"sync/atomic"
 	"testing"
 
@@ -25,6 +26,14 @@ func GetRandomName(t testing.TB) string {
 	return incSuffix(name, n.Add(1), maxNameLen)
 }
 
+// GetRandomNameHyphenated is as GetRandomName but uses a hyphen "-" instead of
+// an underscore.
+func GetRandomNameHyphenated(t testing.TB) string {
+	t.Helper()
+	name := namesgenerator.GetRandomName(0)
+	return strings.ReplaceAll(name, "_", "-")
+}
+
 func incSuffix(s string, num int64, maxLen int) string {
 	suffix := strconv.FormatInt(num, 10)
 	if len(s)+len(suffix) <= maxLen {
