Lock before modification

dannykopping · dannykopping · commit 24417c55d337 · 2024-07-10T14:57:35.000Z
Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -930,6 +930,9 @@ func (q *FakeQuerier) AcquireNotificationMessages(_ context.Context, arg databas
 		return nil, err
 	}
 
+	q.mutex.Lock()
+	defer q.mutex.Unlock()
+
 	// Shift the first "Count" notifications off the slice (FIFO).
 	sz := len(q.notificationMessages)
 	if sz > int(arg.Count) {
@@ -939,9 +942,6 @@ func (q *FakeQuerier) AcquireNotificationMessages(_ context.Context, arg databas
 	list := q.notificationMessages[:sz]
 	q.notificationMessages = q.notificationMessages[sz:]
 
-	q.mutex.Lock()
-	defer q.mutex.Unlock()
-
 	var out []database.AcquireNotificationMessagesRow
 	for _, nm := range list {
 		acquirableStatuses := []database.NotificationMessageStatus{database.NotificationMessageStatusPending, database.NotificationMessageStatusTemporaryFailure}
