prevent duplicates

sreya · sreya · commit 2b521694201c · 2022-06-24T22:17:16.000Z
diff --git a/cli/root.go b/cli/root.go
@@ -65,11 +65,17 @@ func Root() *cobra.Command {
 		SilenceUsage:  true,
 		Long: `Coder — A tool for provisioning self-hosted development environments.
 `,
-		PersistentPreRunE: func(cmd *cobra.Command, _ []string) error {
+		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
 			if varSuppressVersion {
 				return nil
 			}
 
+			// Login handles checking the versions itself since it
+			// has a handle to an unauthenticated client.
+			if cmd.Name() == "login" {
+				return nil
+			}
+
 			client, err := createClient(cmd)
 			// If the client is unauthenticated we can ignore the check.
 			// The child commands should handle an unauthenticated client.
@@ -357,6 +363,10 @@ func FormatCobraError(err error, cmd *cobra.Command) string {
 }
 
 func checkVersions(cmd *cobra.Command, client *codersdk.Client) error {
+	if varSuppressVersion {
+		return nil
+	}
+
 	clientVersion := buildinfo.Version()
 
 	info, err := client.BuildInfo(cmd.Context())
