fix

mtojek · mtojek · commit 3ace8c679b82 · 2024-07-15T14:12:52.000+02:00
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1103,9 +1103,8 @@ func (s *server) notifyWorkspaceBuildFailed(ctx context.Context, workspace datab
 
 	if _, err := s.NotificationEnqueuer.Enqueue(ctx, workspace.OwnerID, notifications.WorkspaceAutobuildFailed,
 		map[string]string{
-			"name":      workspace.Name,
-			"initiator": build.InitiatorByUsername,
-			"reason":    reason,
+			"name":   workspace.Name,
+			"reason": reason,
 		}, "provisionerdserver",
 		// Associate this notification with all the related entities.
 		workspace.ID, workspace.OwnerID, workspace.TemplateID, workspace.OrganizationID,
diff --git a/coderd/provisionerdserver/provisionerdserver_test.go b/coderd/provisionerdserver/provisionerdserver_test.go
@@ -1714,6 +1714,9 @@ func TestNotifications(t *testing.T) {
 					require.Contains(t, notifEnq.sent[0].targets, user.ID)
 					if tc.buildReason == database.BuildReasonInitiator {
 						require.Equal(t, notifEnq.sent[0].labels["initiator"], initiator.Username)
+					} else {
+						_, ok := notifEnq.sent[0].labels["initiator"]
+						require.False(t, ok, "initiator label not expected")
 					}
 				} else {
 					require.Len(t, notifEnq.sent, 0)
