Fix comments

kylecarbs · kylecarbs · commit 45c0aca3ad44 · 2023-03-22T22:16:27.000Z
diff --git a/agent/agent.go b/agent/agent.go
@@ -778,7 +778,9 @@ func (a *agent) trackScriptLogs(ctx context.Context, reader io.Reader) (chan str
 	// coming in.
 	logsFinished := make(chan struct{})
 	err := a.trackConnGoroutine(func() {
+		buffer := make([]byte, 0, 1<<20)
 		scanner := bufio.NewScanner(reader)
+		scanner.Buffer(buffer, 1<<20)
 		for scanner.Scan() {
 			queueLog(agentsdk.StartupLog{
 				CreatedAt: database.Now(),
diff --git a/coderd/database/migrations/000110_add_startup_logs.up.sql b/coderd/database/migrations/000110_add_startup_logs.up.sql
@@ -1,3 +1,5 @@
+BEGIN;
+
 CREATE TABLE IF NOT EXISTS workspace_agent_startup_logs (
     agent_id uuid NOT NULL REFERENCES workspace_agents (id) ON DELETE CASCADE,
     created_at timestamptz NOT NULL,
@@ -12,3 +14,5 @@ ALTER TABLE workspace_agents ADD COLUMN startup_logs_overflowed boolean NOT NULL
 
 COMMENT ON COLUMN workspace_agents.startup_logs_length IS 'Total length of startup logs';
 COMMENT ON COLUMN workspace_agents.startup_logs_overflowed IS 'Whether the startup logs overflowed in length';
+
+COMMIT;
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go
@@ -423,7 +423,6 @@ func (api *API) workspaceAgentStartupLogs(rw http.ResponseWriter, r *http.Reques
 	}
 
 	var (
-		// It's not impossible that
 		bufferedLogs  = make(chan []database.WorkspaceAgentStartupLog, 128)
 		endOfLogs     atomic.Bool
 		lastSentLogID atomic.Int64

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,6 @@ func (api API) workspaceAgentStartupLogs(rw http.ResponseWriter, r http.Reques`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`var (`
`426`		`- // It's not impossible that`
`427`	`426`	`bufferedLogs = make(chan []database.WorkspaceAgentStartupLog, 128)`
`428`	`427`	`endOfLogs atomic.Bool`
`429`	`428`	`lastSentLogID atomic.Int64`