fix tests

f0ssel · f0ssel · commit 4aea7a0a1faf · 2022-06-02T22:10:00.000Z
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -328,6 +328,9 @@ func (q *fakeQuerier) GetWorkspacesWithFilter(_ context.Context, arg database.Ge
 		if !arg.Deleted && workspace.Deleted {
 			continue
 		}
+		if arg.Name != "" && workspace.Name != arg.Name {
+			continue
+		}
 		workspaces = append(workspaces, workspace)
 	}
 
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -268,6 +268,36 @@ func TestWorkspacesByOwner(t *testing.T) {
 		require.NoError(t, err)
 		require.Len(t, workspaces, 1)
 	})
+
+	t.Run("ListName", func(t *testing.T) {
+		t.Parallel()
+		client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerD: true})
+		user := coderdtest.CreateFirstUser(t, client)
+
+		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
+		coderdtest.AwaitTemplateVersionJob(t, client, version.ID)
+		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
+		w := coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID)
+
+		// Create noise workspace that should be filtered out
+		_ = coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID)
+
+		// Use name filter
+		workspaces, err := client.Workspaces(context.Background(), codersdk.WorkspaceFilter{
+			Name: w.Name,
+		})
+		require.NoError(t, err)
+		require.Len(t, workspaces, 1)
+
+		// Create same name workspace that should be included
+		_ = coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) { cwr.Name = w.Name })
+
+		workspaces, err = client.Workspaces(context.Background(), codersdk.WorkspaceFilter{
+			Name: w.Name,
+		})
+		require.NoError(t, err)
+		require.Len(t, workspaces, 2)
+	})
 }
 
 func TestWorkspaceByOwnerAndName(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -328,6 +328,9 @@ func (q *fakeQuerier) GetWorkspacesWithFilter(_ context.Context, arg database.Ge`
`328`	`328`	`if !arg.Deleted && workspace.Deleted {`
`329`	`329`	`continue`
`330`	`330`	`}`
	`331`	`+ if arg.Name != "" && workspace.Name != arg.Name {`
	`332`	`+ continue`
	`333`	`+ }`
`331`	`334`	`workspaces = append(workspaces, workspace)`
`332`	`335`	`}`
`333`	`336`