chore: move vscode local out of experiments (#5773)

kylecarbs · web-flow · commit 546a8931aa40 · 2023-01-20T04:32:59.000Z
We've been dogfooding the VS Code extension for a while,
and it seems stable enough that it's overall positive
to release!
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/experiments_test.go b/coderd/experiments_test.go
@@ -29,7 +29,6 @@ func Test_Experiments(t *testing.T) {
 		require.NoError(t, err)
 		require.NotNil(t, experiments)
 		require.Empty(t, experiments)
-		require.False(t, experiments.Enabled(codersdk.ExperimentVSCodeLocal))
 		require.False(t, experiments.Enabled("foo"))
 	})
 
diff --git a/codersdk/experiments.go b/codersdk/experiments.go
@@ -9,19 +9,16 @@ import (
 type Experiment string
 
 const (
-	// ExperimentVSCodeLocal enables a workspace button to launch VSCode
-	// and connect using the local VSCode extension.
-	ExperimentVSCodeLocal Experiment = "vscode_local"
+// Add new experiments here!
+// ExperimentExample Experiment = "example"
 )
 
 var (
 	// ExperimentsAll should include all experiments that are safe for
 	// users to opt-in to via --experimental='*'.
 	// Experiments that are not ready for consumption by all users should
 	// not be included here and will be essentially hidden.
-	ExperimentsAll = Experiments{
-		ExperimentVSCodeLocal,
-	}
+	ExperimentsAll = Experiments{}
 )
 
 // Experiments is a list of experiments that are enabled for the deployment.
diff --git a/docs/api/general.md b/docs/api/general.md
@@ -1072,23 +1072,17 @@ curl -X GET http://coder-server:8080/api/v2/experiments \
 > 200 Response
 
 ```json
-["vscode_local"]
+["string"]
 ```
 
 ### Responses
 
-| Status | Meaning                                                 | Description | Schema                                                        |
-| ------ | ------------------------------------------------------- | ----------- | ------------------------------------------------------------- |
-| 200    | [OK](https://tools.ietf.org/html/rfc7231#section-6.3.1) | OK          | array of [codersdk.Experiment](schemas.md#codersdkexperiment) |
+| Status | Meaning                                                 | Description | Schema          |
+| ------ | ------------------------------------------------------- | ----------- | --------------- |
+| 200    | [OK](https://tools.ietf.org/html/rfc7231#section-6.3.1) | OK          | array of string |
 
 <h3 id="get-experiments-responseschema">Response Schema</h3>
 
-Status Code **200**
-
-| Name           | Type  | Required | Restrictions | Description |
-| -------------- | ----- | -------- | ------------ | ----------- |
-| `[array item]` | array | false    |              |             |
-
 To perform this operation, you must be authenticated. [Learn more](authentication.md).
 
 ## Update check
diff --git a/docs/api/schemas.md b/docs/api/schemas.md
@@ -2427,20 +2427,6 @@ CreateParameterRequest is a structure used to create a new parameter value for a
 | `trial`            | boolean                              | false    |              |                                       |
 | `warnings`         | array of string                      | false    |              |                                       |
 
-## codersdk.Experiment
-
-```json
-"vscode_local"
-```
-
-### Properties
-
-#### Enumerated Values
-
-| Value          |
-| -------------- |
-| `vscode_local` |
-
 ## codersdk.Feature
 
 ```json
diff --git a/scripts/apitypings/main.go b/scripts/apitypings/main.go
@@ -223,8 +223,13 @@ func (g *Generator) generateAll() (*TypescriptTypes, error) {
 		sort.Strings(values)
 		var s strings.Builder
 		_, _ = s.WriteString(g.posLine(v))
+		joined := strings.Join(values, " | ")
+		if joined == "" {
+			// It's possible an enum has no values.
+			joined = "never"
+		}
 		_, _ = s.WriteString(fmt.Sprintf("export type %s = %s\n",
-			name, strings.Join(values, " | "),
+			name, joined,
 		))
 
 		var pluralName string
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -1092,8 +1092,8 @@ export const Entitlements: Entitlement[] = [
 ]
 
 // From codersdk/experiments.go
-export type Experiment = "vscode_local"
-export const Experiments: Experiment[] = ["vscode_local"]
+export type Experiment = never
+export const Experiments: Experiment[] = []
 
 // From codersdk/features.go
 export type FeatureName =
diff --git a/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx b/site/src/pages/WorkspacePage/WorkspaceReadyPage.tsx
@@ -40,7 +40,7 @@ export const WorkspaceReadyPage = ({
   const [_, bannerSend] = useActor(
     workspaceState.children["scheduleBannerMachine"],
   )
-  const { buildInfo, experiments } = useDashboard()
+  const { buildInfo } = useDashboard()
   const featureVisibility = useFeatureVisibility()
   const {
     workspace,
@@ -115,10 +115,7 @@ export const WorkspaceReadyPage = ({
         builds={builds}
         canUpdateWorkspace={canUpdateWorkspace}
         hideSSHButton={featureVisibility["browser_only"]}
-        hideVSCodeDesktopButton={
-          !experiments.includes("vscode_local") ||
-          featureVisibility["browser_only"]
-        }
+        hideVSCodeDesktopButton={featureVisibility["browser_only"]}
         workspaceErrors={{
           [WorkspaceErrors.GET_RESOURCES_ERROR]: refreshWorkspaceWarning,
           [WorkspaceErrors.GET_BUILDS_ERROR]: getBuildsError,
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -982,7 +982,7 @@ export const MockEntitlementsWithAuditLog: TypesGen.Entitlements = {
   }),
 }
 
-export const MockExperiments: TypesGen.Experiment[] = ["vscode_local"]
+export const MockExperiments: TypesGen.Experiment[] = []
 
 export const MockAuditLog: TypesGen.AuditLog = {
   id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",

Original file line number	Diff line number	Diff line change
`@@ -1092,8 +1092,8 @@ export const Entitlements: Entitlement[] = [`
`1092`	`1092`	`]`
`1093`	`1093`
`1094`	`1094`	`// From codersdk/experiments.go`
`1095`		`-export type Experiment = "vscode_local"`
`1096`		`-export const Experiments: Experiment[] = ["vscode_local"]`
	`1095`	`+export type Experiment = never`
	`1096`	`+export const Experiments: Experiment[] = []`
`1097`	`1097`
`1098`	`1098`	`// From codersdk/features.go`
`1099`	`1099`	`export type FeatureName =`
Original file line number	Diff line number	Diff line change
`@@ -982,7 +982,7 @@ export const MockEntitlementsWithAuditLog: TypesGen.Entitlements = {`
`982`	`982`	`}),`
`983`	`983`	`}`
`984`	`984`
`985`		`-export const MockExperiments: TypesGen.Experiment[] = ["vscode_local"]`
	`985`	`+export const MockExperiments: TypesGen.Experiment[] = []`
`986`	`986`
`987`	`987`	`export const MockAuditLog: TypesGen.AuditLog = {`
`988`	`988`	`id: "fbd2116a-8961-4954-87ae-e4575bd29ce0",`