fix: allow delesecting a preset without triggering a validation error

SasSwart · SasSwart · commit 5dd8416cb9a2 · 2025-06-23T12:40:24.000Z
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
@@ -201,6 +201,42 @@ export const PresetReselected: Story = {
 	},
 };
 
+export const PresetNoneSelected: Story = {
+	args: {
+		...PresetsButNoneSelected.args,
+		onSubmit: (request, owner) => {
+			// Assert that template_version_preset_id is not present in the request
+			console.assert(
+				!('template_version_preset_id' in request),
+				'template_version_preset_id should not be present when "None" is selected'
+			);
+			action('onSubmit')(request, owner);
+		},
+	},
+	play: async ({ canvasElement }) => {
+		const canvas = within(canvasElement);
+
+		// First select a preset to set the field value
+		await userEvent.click(canvas.getByLabelText("Preset"));
+		await userEvent.click(canvas.getByText("Preset 1"));
+
+		// Then select "None" to unset the field value
+		await userEvent.click(canvas.getByLabelText("Preset"));
+		await userEvent.click(canvas.getByText("None"));
+
+		// Fill in required fields and submit to test the API call
+		await userEvent.type(canvas.getByLabelText("Workspace Name"), "test-workspace");
+		await userEvent.click(canvas.getByText("Create workspace"));
+	},
+	parameters: {
+		docs: {
+			description: {
+				story: "This story tests that when 'None' preset is selected, the template_version_preset_id field is not included in the form submission. The story first selects a preset to set the field value, then selects 'None' to unset it, and finally submits the form to verify the API call behavior.",
+			},
+		},
+	},
+};
+
 export const ExternalAuth: Story = {
 	args: {
 		externalAuth: [
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx
@@ -369,7 +369,7 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
 													setSelectedPresetIndex(index);
 													form.setFieldValue(
 														"template_version_preset_id",
-														option?.value,
+														index === 0 ? undefined : option?.value,
 													);
 												}}
 												placeholder="Select a preset"
