feat(coderd): increase group name limit to 255

BrunoQuaresma · BrunoQuaresma · commit 64d2a7556236 · 2024-11-05T13:16:31.000Z
diff --git a/codersdk/name.go b/codersdk/name.go
@@ -1,6 +1,7 @@
 package codersdk
 
 import (
+	"fmt"
 	"regexp"
 	"strings"
 
@@ -98,9 +99,12 @@ func UserRealNameValid(str string) error {
 
 // GroupNameValid returns whether the input string is a valid group name.
 func GroupNameValid(str string) error {
-	// 36 is to support using UUIDs as the group name.
-	if len(str) > 36 {
-		return xerrors.New("must be <= 36 characters")
+	// We want to support longer names for groups to allow users to sync their
+	// group names with their identity providers without manual mapping. Related
+	// to: https://github.com/coder/coder/issues/15184
+	limit := 255
+	if len(str) > limit {
+		return xerrors.New(fmt.Sprintf("must be <= %d characters", limit))
 	}
 	// Avoid conflicts with routes like /groups/new and /groups/create.
 	if str == "new" || str == "create" {
diff --git a/codersdk/name_test.go b/codersdk/name_test.go
@@ -3,9 +3,11 @@ package codersdk_test
 import (
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"golang.org/x/exp/rand"
 
 	"github.com/coder/coder/v2/codersdk"
 	"github.com/coder/coder/v2/testutil"
@@ -254,3 +256,40 @@ func TestUserRealNameValid(t *testing.T) {
 		})
 	}
 }
+
+func TestGroupNameValid(t *testing.T) {
+	t.Parallel()
+
+	testCases := []struct {
+		Name  string
+		Valid bool
+	}{
+		{"", false},
+		{"my-group", true},
+		{"create", false},
+		{"new", false},
+		{"Lord Voldemort Team", false},
+		{randomString(255), true},
+		{randomString(256), false},
+	}
+	for _, testCase := range testCases {
+		testCase := testCase
+		t.Run(testCase.Name, func(t *testing.T) {
+			t.Parallel()
+			err := codersdk.GroupNameValid(testCase.Name)
+			assert.Equal(t, testCase.Valid, err == nil)
+		})
+	}
+}
+
+const charset = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
+
+// RandomString generates a random string of a given length.
+func randomString(length int) string {
+	seededRand := rand.New(rand.NewSource(uint64(time.Now().UnixNano())))
+	result := make([]byte, length)
+	for i := range result {
+		result[i] = charset[seededRand.Intn(len(charset))]
+	}
+	return string(result)
+}
