Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 6bdddd5

Browse files
chore: show server install.sh on cli version mismatch (#16668)
This PR has the CLI show the server's own `install.sh` script if there's a version mismatch, and if the deployment doesn't have an custom upgrade message configured. ``` $ coder ls version mismatch: client {version}, server {version} download {server_version} with: 'curl -fsSL https://dev.coder.com/install.sh | sh' [ ... ] ```
1 parent 754c5db commit 6bdddd5

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

cli/root.go

+8-3
Original file line numberDiff line numberDiff line change
@@ -1213,9 +1213,14 @@ func wrapTransportWithVersionMismatchCheck(rt http.RoundTripper, inv *serpent.In
12131213
return
12141214
}
12151215
upgradeMessage := defaultUpgradeMessage(semver.Canonical(serverVersion))
1216-
serverInfo, err := getBuildInfo(inv.Context())
1217-
if err == nil && serverInfo.UpgradeMessage != "" {
1218-
upgradeMessage = serverInfo.UpgradeMessage
1216+
if serverInfo, err := getBuildInfo(inv.Context()); err == nil {
1217+
switch {
1218+
case serverInfo.UpgradeMessage != "":
1219+
upgradeMessage = serverInfo.UpgradeMessage
1220+
// The site-local `install.sh` was introduced in v2.19.0
1221+
case serverInfo.DashboardURL != "" && semver.Compare(semver.MajorMinor(serverVersion), "v2.19") >= 0:
1222+
upgradeMessage = fmt.Sprintf("download %s with: 'curl -fsSL %s/install.sh | sh'", serverVersion, serverInfo.DashboardURL)
1223+
}
12191224
}
12201225
fmtWarningText := "version mismatch: client %s, server %s\n%s"
12211226
fmtWarn := pretty.Sprint(cliui.DefaultStyles.Warn, fmtWarningText)

0 commit comments

Comments
 (0)