golint

mtojek · mtojek · commit 7d61b551e2b7 · 2023-01-13T17:09:08.000+01:00
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -1367,7 +1367,7 @@ func (q *fakeQuerier) GetWorkspaceBuildByWorkspaceIDAndBuildNumber(_ context.Con
 	return database.WorkspaceBuild{}, sql.ErrNoRows
 }
 
-func (q *fakeQuerier) GetWorkspaceBuildParameters(ctx context.Context, workspaceBuildID uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
+func (q *fakeQuerier) GetWorkspaceBuildParameters(_ context.Context, workspaceBuildID uuid.UUID) ([]database.WorkspaceBuildParameter, error) {
 	q.mutex.RLock()
 	defer q.mutex.RUnlock()
 
@@ -2428,10 +2428,11 @@ func (q *fakeQuerier) InsertTemplateVersion(_ context.Context, arg database.Inse
 	return version, nil
 }
 
-func (q *fakeQuerier) InsertTemplateVersionParameter(ctx context.Context, arg database.InsertTemplateVersionParameterParams) (database.TemplateVersionParameter, error) {
+func (q *fakeQuerier) InsertTemplateVersionParameter(_ context.Context, arg database.InsertTemplateVersionParameterParams) (database.TemplateVersionParameter, error) {
 	q.mutex.Lock()
 	defer q.mutex.Unlock()
 
+	//nolint:gosimple
 	param := database.TemplateVersionParameter{
 		TemplateVersionID: arg.TemplateVersionID,
 		Name:              arg.Name,
@@ -2774,7 +2775,7 @@ func (q *fakeQuerier) InsertWorkspaceBuild(_ context.Context, arg database.Inser
 	return workspaceBuild, nil
 }
 
-func (q *fakeQuerier) InsertWorkspaceBuildParameters(ctx context.Context, arg database.InsertWorkspaceBuildParametersParams) error {
+func (q *fakeQuerier) InsertWorkspaceBuildParameters(_ context.Context, arg database.InsertWorkspaceBuildParametersParams) error {
 	q.mutex.Lock()
 	defer q.mutex.Unlock()
 
diff --git a/coderd/templateversions.go b/coderd/templateversions.go
@@ -231,7 +231,7 @@ func (api *API) templateVersionRichParameters(rw http.ResponseWriter, r *http.Re
 		})
 		return
 	}
-	parameters := make([]codersdk.TemplateVersionParameter, 0)
+	params := make([]codersdk.TemplateVersionParameter, 0)
 	for _, dbParameter := range dbParameters {
 		parameter, err := convertTemplateVersionParameter(dbParameter)
 		if err != nil {
@@ -241,9 +241,9 @@ func (api *API) templateVersionRichParameters(rw http.ResponseWriter, r *http.Re
 			})
 			return
 		}
-		parameters = append(parameters, parameter)
+		params = append(params, parameter)
 	}
-	httpapi.Write(ctx, rw, http.StatusOK, parameters)
+	httpapi.Write(ctx, rw, http.StatusOK, params)
 }
 
 // @Summary Get parameters by template version

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@ func (api API) templateVersionRichParameters(rw http.ResponseWriter, r http.Re`
`231`	`231`	`})`
`232`	`232`	`return`
`233`	`233`	`}`
`234`		`- parameters := make([]codersdk.TemplateVersionParameter, 0)`
	`234`	`+ params := make([]codersdk.TemplateVersionParameter, 0)`
`235`	`235`	`for _, dbParameter := range dbParameters {`
`236`	`236`	`parameter, err := convertTemplateVersionParameter(dbParameter)`
`237`	`237`	`if err != nil {`
`@@ -241,9 +241,9 @@ func (api API) templateVersionRichParameters(rw http.ResponseWriter, r http.Re`
`241`	`241`	`})`
`242`	`242`	`return`
`243`	`243`	`}`
`244`		`- parameters = append(parameters, parameter)`
	`244`	`+ params = append(params, parameter)`
`245`	`245`	`}`
`246`		`- httpapi.Write(ctx, rw, http.StatusOK, parameters)`
	`246`	`+ httpapi.Write(ctx, rw, http.StatusOK, params)`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`// @Summary Get parameters by template version`