refactor: name null users in audit logs

BrunoQuaresma · BrunoQuaresma · commit a27a8f0872dd · 2025-03-12T13:57:42.000Z
diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.stories.tsx
@@ -105,3 +105,12 @@ export const SCIMUpdateUser: Story = {
 		},
 	},
 };
+
+export const UnauthenticatedUser: Story = {
+	args: {
+		auditLog: {
+			...MockAuditLog,
+			user: null,
+		},
+	},
+};
diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/AuditLogDescription.tsx
@@ -19,7 +19,9 @@ export const AuditLogDescription: FC<AuditLogDescriptionProps> = ({
 	}
 
 	let target = auditLog.resource_target.trim();
-	let user = auditLog.user?.username.trim();
+	let user = auditLog.user
+		? auditLog.user.username.trim()
+		: "Unauthenticated user";
 
 	// SSH key entries have no links
 	if (auditLog.resource_type === "git_ssh_key") {
diff --git a/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx b/site/src/pages/AuditPage/AuditLogRow/AuditLogDescription/BuildAuditDescription.tsx
@@ -16,7 +16,9 @@ export const BuildAuditDescription: FC<BuildAuditDescriptionProps> = ({
 		auditLog.additional_fields?.build_reason &&
 		auditLog.additional_fields?.build_reason !== "initiator"
 			? "Coder automatically"
-			: auditLog.user?.username.trim();
+			: auditLog.user
+				? auditLog.user.username.trim()
+				: "Unauthenticated user";
 
 	const action = useMemo(() => {
 		switch (auditLog.action) {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,9 @@ export const AuditLogDescription: FC<AuditLogDescriptionProps> = ({`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`let target = auditLog.resource_target.trim();`
`22`		`- let user = auditLog.user?.username.trim();`
	`22`	`+ let user = auditLog.user`
	`23`	`+ ? auditLog.user.username.trim()`
	`24`	`+ : "Unauthenticated user";`
`23`	`25`
`24`	`26`	`// SSH key entries have no links`
`25`	`27`	`if (auditLog.resource_type === "git_ssh_key") {`