chore: update to use parameter styling type

jaaydenh · jaaydenh · commit c690c7bd2d0c · 2025-05-07T21:14:23.000Z
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -36,12 +36,6 @@ import { type FC, useEffect, useId, useState } from "react";
 import type { AutofillBuildParameter } from "utils/richParameters";
 import * as Yup from "yup";
 
-export interface ParameterStyling {
-	placeholder?: string;
-	label?: string;
-	disabled?: boolean;
-}
-
 export interface DynamicParameterProps {
 	parameter: PreviewParameter;
 	onChange: (value: string) => void;
@@ -170,7 +164,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
 	id,
 }) => {
 	const value = validValue(parameter.value);
-	const styling = parameter.styling as ParameterStyling;
 	const [localValue, setLocalValue] = useState(value);
 
 	useEffect(() => {
@@ -188,7 +181,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 				>
 					<SelectTrigger>
 						<SelectValue
-							placeholder={styling?.placeholder || "Select option"}
+							placeholder={parameter.styling?.placeholder || "Select option"}
 						/>
 					</SelectTrigger>
 					<SelectContent>
@@ -249,7 +242,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 						onChange(JSON.stringify(values));
 					}}
 					hidePlaceholderWhenSelected
-					placeholder={styling?.placeholder || "Select option"}
+					placeholder={parameter.styling?.placeholder || "Select option"}
 					emptyIndicator={
 						<p className="text-center text-md text-content-primary">
 							No results found
@@ -305,7 +298,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 						}}
 						disabled={disabled}
 					/>
-					<Label htmlFor={parameter.name}>{styling?.label}</Label>
+					<Label htmlFor={parameter.name}>{parameter.styling?.label}</Label>
 				</div>
 			);
 
@@ -342,7 +335,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 						target.style.height = `${target.scrollHeight}px`;
 					}}
 					disabled={disabled}
-					placeholder={styling?.placeholder}
+					placeholder={parameter.styling?.placeholder}
 					required={parameter.required}
 				/>
 			);
@@ -374,7 +367,7 @@ const ParameterField: FC<ParameterFieldProps> = ({
 					}}
 					disabled={disabled}
 					required={parameter.required}
-					placeholder={styling?.placeholder}
+					placeholder={parameter.styling?.placeholder}
 					{...inputProps}
 				/>
 			);
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -23,7 +23,6 @@ import { useDebouncedFunction } from "hooks/debounce";
 import { ArrowLeft, CircleAlert, TriangleAlert } from "lucide-react";
 import {
 	DynamicParameter,
-	type ParameterStyling,
 	getInitialParameterValues,
 	useValidationSchemaForDynamicParameters,
 } from "modules/workspaces/DynamicParameter/DynamicParameter";
@@ -493,17 +492,15 @@ export const CreateWorkspacePageViewExperimental: FC<
 
 							<div className="flex flex-col gap-9">
 								{parameters.map((parameter, index) => {
-									const styling = parameter.styling as ParameterStyling;
 									const parameterField = `rich_parameter_values.${index}`;
-									const parameterInputName = `${parameterField}.value`;
 									const isPresetParameter = presetParameterNames.includes(
 										parameter.name,
 									);
 									const isDisabled =
 										disabledParams?.includes(
 											parameter.name.toLowerCase().replace(/ /g, "_"),
 										) ||
-										styling?.disabled ||
+										parameter.styling?.disabled ||
 										creatingWorkspace ||
 										isPresetParameter;
 

No results found