Add tests for leak in cli

f0ssel · f0ssel · commit d1cba3201611 · 2022-03-25T22:32:01.000Z
diff --git a/cli/start.go b/cli/start.go
@@ -23,6 +23,8 @@ import (
 	"google.golang.org/api/idtoken"
 	"google.golang.org/api/option"
 
+	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
+
 	"cdr.dev/slog"
 	"cdr.dev/slog/sloggers/sloghuman"
 	"github.com/coder/coder/cli/cliui"
@@ -36,7 +38,6 @@ import (
 	"github.com/coder/coder/provisionerd"
 	"github.com/coder/coder/provisionersdk"
 	"github.com/coder/coder/provisionersdk/proto"
-	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
 )
 
 func start() *cobra.Command {
diff --git a/cli/start_test.go b/cli/start_test.go
@@ -19,6 +19,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+	"go.uber.org/goleak"
 
 	"github.com/coder/coder/cli/clitest"
 	"github.com/coder/coder/coderd/coderdtest"
@@ -198,6 +199,25 @@ func TestStart(t *testing.T) {
 		require.NoError(t, err)
 		<-done
 	})
+	t.Run("DatadogTracerNoLeak", func(t *testing.T) {
+		t.Parallel()
+		ctx, cancelFunc := context.WithCancel(context.Background())
+		defer cancelFunc()
+		os.Setenv("CODER_TRACE_DATADOG", "true")
+		defer func() {
+			os.Unsetenv("CODER_TRACE_DATADOG")
+		}()
+		root, _ := clitest.New(t, "start", "--dev", "--tunnel=false", "--address", ":0")
+		done := make(chan struct{})
+		go func() {
+			defer close(done)
+			err := root.ExecuteContext(ctx)
+			require.ErrorIs(t, err, context.Canceled)
+		}()
+		cancelFunc()
+		<-done
+		require.Error(t, goleak.Find())
+	})
 }
 
 func generateTLSCertificate(t testing.TB) (certPath, keyPath string) {
