:||

aslilac · aslilac · commit e6acf821eab1 · 2025-05-06T18:50:59.000Z
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1452,15 +1452,16 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
 
 					// nolint:gocritic // Requires reading "system" files
 					file, err := tx.GetFileByHashAndCreator(dbauthz.AsSystemRestricted(ctx), database.GetFileByHashAndCreatorParams{Hash: hash, CreatedBy: uuid.Nil})
-					if err == nil {
+					switch {
+					case err == nil:
 						// This set of modules is already cached, which means we can reuse them
 						fileID = uuid.NullUUID{
 							Valid: true,
 							UUID:  file.ID,
 						}
-					} else if !xerrors.Is(err, sql.ErrNoRows) {
+					case !xerrors.Is(err, sql.ErrNoRows):
 						return xerrors.Errorf("check for cached modules: %w", err)
-					} else {
+					default:
 						// nolint:gocritic // Requires creating a "system" file
 						file, err = tx.InsertFile(dbauthz.AsSystemRestricted(ctx), database.InsertFileParams{
 							ID:        uuid.New(),
