Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore: Add missing read perm to RoleAuditor #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #671
greyscaled opened this issue Apr 19, 2022 · 5 comments
Closed
Tracked by #671

Chore: Add missing read perm to RoleAuditor #1074

greyscaled opened this issue Apr 19, 2022 · 5 comments
Assignees
@Emyrk
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@greyscaled
Copy link
Contributor

Overview

This comment was in rbac > role.go for RoleAuditor:

// TODO: @emyrk when audit logs are added, add back a read perm

This is blocked by audit log backend.

See #1066
@greyscaled greyscaled mentioned this issue Apr 19, 2022
Merged
@misskniss misskniss added site Area: frontend dashboard api Area: HTTP API needs grooming 🪒 labels Apr 26, 2022
@misskniss misskniss added needs grooming 🪒 and removed needs grooming 🪒 site Area: frontend dashboard labels May 12, 2022
@misskniss misskniss added this to the Community MVP milestone May 17, 2022
@misskniss
Copy link

@Emyrk does this get fixed with the PR you are currently working on? Also this does seem like something that is a switch blocker, yes?

@misskniss
Copy link

Please add your planning poker estimate with ZenHub @Emyrk

@Emyrk
Copy link
Member

Emyrk commented May 17, 2022

@misskniss it does not. It isn't relevant until audit logs are in though.

@misskniss misskniss mentioned this issue Jun 1, 2022
Closed
6 tasks
@Emyrk
Copy link
Member

Emyrk commented Jun 1, 2022

Can we just delete this? We don't have audit logs, so this can't be done. I shouldn't have added the auditor role probably...

When audit logs are added, this is a 1 line change.

@Emyrk
Copy link
Member

Emyrk commented Jun 2, 2022

This is not worth an issue right now. When we add audit logs, we should update the Auditor role. I think that is apart of the Audit log effort.

Closing this

@Emyrk Emyrk closed this as completed Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

No branches or pull requests
3 participants
@misskniss @Emyrk @greyscaled