chore: replace todos with issues#1066
Merged
Merged
Conversation
This was referenced Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #1066 +/- ##
=======================================
Coverage 66.79% 66.80%
=======================================
Files 262 262
Lines 15653 15660 +7
Branches 152 152
=======================================
+ Hits 10456 10462 +6
- Misses 4136 4137 +1
Partials 1061 1061
Continue to review full report at Codecov.
|
This was referenced Apr 19, 2022
Closed
greyscaled
commented
Apr 19, 2022
| .PHONY: fmt/prettier | ||
|
|
||
| fmt/sql: $(wildcard coderd/database/queries/*.sql) | ||
| # TODO: this is slightly slow |
greyscaled
commented
Apr 19, 2022
|
|
||
| // Get returns the $SHELL environment variable. | ||
| // TODO: This should use "dscl" to fetch the proper value. See: | ||
| // https://stackoverflow.com/questions/16375519/how-to-get-the-default-shell |
greyscaled
commented
Apr 19, 2022
| Long: autostartDescriptionLong, | ||
| Example: "coder workspaces autostart enable my-workspace --minute 30 --hour 9 --days 1-5 --tz Europe/Dublin", | ||
| Hidden: true, // TODO(cian): un-hide when autostart scheduling implemented | ||
| Hidden: true, |
greyscaled
commented
Apr 19, 2022
| Long: autostopDescriptionLong, | ||
| Example: "coder workspaces autostop enable my-workspace --minute 0 --hour 18 --days 1-5 -tz Europe/Dublin", | ||
| Hidden: true, // TODO(cian): un-hide when autostop scheduling implemented | ||
| Hidden: true, |
greyscaled
commented
Apr 19, 2022
| Site []Permission `json:"site"` | ||
| // Org is a map of orgid to permissions. We represent orgid as a string. | ||
| // TODO: Maybe switch to uuid, but tokens might need to support a "wildcard" org | ||
| // which could be a special uuid (like all 0s?) |
greyscaled
commented
Apr 19, 2022
| RoleAuditor = Role{ | ||
| Name: "auditor", | ||
| Site: permissions(map[Object][]Action{ | ||
| // TODO: @emyrk when audit logs are added, add back a read perm |
greyscaled
commented
Apr 19, 2022
| // be pooled so synchronously, but is definitely possible. | ||
| // REMARK: There's an obvious race-condition here. This is an edge-case, as | ||
| // most-frequently data won't be pooled so synchronously, but is | ||
| // definitely possible. |
greyscaled
commented
Apr 19, 2022
| // Only scripts can manipulate the dom. This prevents someone from | ||
| // naming themselves something like '<svg onload="alert(/cross-site-scripting/)" />'. | ||
| // TODO: @emyrk we need to make FE changes to enable this. We get 'TrustedHTML' and 'TrustedURL' errors | ||
| // that require FE changes to work. |
greyscaled
commented
Apr 19, 2022
| // workspaces per-template. This just grabs all workspaces... and then | ||
| // later filters them to match the current template. | ||
| // This just grabs all workspaces... and then later filters them to match the | ||
| // current template. |
presleyp
approved these changes
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #971