Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: replace todos with issues #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2022
Merged

chore: replace todos with issues #1066

merged 6 commits into from
Apr 19, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Apr 19, 2022 •
edited
Loading

Resolves: #971

@greyscaled greyscaled self-assigned this Apr 19, 2022
This was referenced Apr 19, 2022
Closed
Closed
@greyscaled greyscaled mentioned this pull request Apr 19, 2022
Closed
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1066 (305b97b) into main (c8246e3) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   66.79%   66.80%           
=======================================
  Files         262      262           
  Lines       15653    15660    +7     
  Branches      152      152           
=======================================
+ Hits        10456    10462    +6     
- Misses       4136     4137    +1     
  Partials     1061     1061
Flag Coverage Δ
unittest-go-macos-latest 53.62% <100.00%> (+0.02%) ⬆️
unittest-go-postgres- 65.80% <100.00%> (-0.17%) ⬇️
unittest-go-ubuntu-latest 55.96% <100.00%> (+0.09%) ⬆️
unittest-go-windows-2022 52.92% <100.00%> (+<0.01%) ⬆️
unittest-js 67.96% <0.00%> (ø)
Impacted Files Coverage Δ
agent/usershell/usershell_darwin.go 100.00% <ø> (ø)
coderd/rbac/role.go 100.00% <ø> (ø)
peer/channel.go 83.23% <ø> (ø)
site/src/components/Form/FormTextField.tsx 59.37% <0.00%> (ø)
...ages/templates/[organization]/[template]/index.tsx 0.00% <ø> (ø)
cli/workspaceautostart.go 80.76% <100.00%> (ø)
cli/workspaceautostop.go 80.76% <100.00%> (ø)
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 81.17% <0.00%> (-0.74%) ⬇️
coderd/provisionerdaemons.go 59.86% <0.00%> (-0.52%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8246e3...305b97b. Read the comment docs.

This was referenced Apr 19, 2022
Closed
Closed
@greyscaled greyscaled mentioned this pull request Apr 19, 2022
Closed
@greyscaled greyscaled mentioned this pull request Apr 19, 2022
Closed
@greyscaled greyscaled mentioned this pull request Apr 19, 2022
Closed
@greyscaled greyscaled marked this pull request as ready for review April 19, 2022 16:06
@greyscaled greyscaled requested a review from a team as a code owner April 19, 2022 16:06
@greyscaled greyscaled requested a review from a team April 19, 2022 16:06
greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
Makefile
@@ -35,7 +35,6 @@ endif
.PHONY: fmt/prettier

fmt/sql: $(wildcard coderd/database/queries/*.sql)
# TODO: this is slightly slow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1067

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
agent/usershell/usershell_darwin.go
@@ -3,8 +3,6 @@ package usershell
import "os"

// Get returns the $SHELL environment variable.
// TODO: This should use "dscl" to fetch the proper value. See:
// https://stackoverflow.com/questions/16375519/how-to-get-the-default-shell
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1068

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
cli/workspaceautostart.go
@@ -22,7 +22,7 @@ func workspaceAutostart() *cobra.Command {
Short: "schedule a workspace to automatically start at a regular time",
Long: autostartDescriptionLong,
Example: "coder workspaces autostart enable my-workspace --minute 30 --hour 9 --days 1-5 --tz Europe/Dublin",
Hidden: true, // TODO(cian): un-hide when autostart scheduling implemented
Hidden: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1069

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
cli/workspaceautostop.go
@@ -22,7 +22,7 @@ func workspaceAutostop() *cobra.Command {
Short: "schedule a workspace to automatically stop at a regular time",
Long: autostopDescriptionLong,
Example: "coder workspaces autostop enable my-workspace --minute 0 --hour 18 --days 1-5 -tz Europe/Dublin",
Hidden: true, // TODO(cian): un-hide when autostop scheduling implemented
Hidden: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1069

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
coderd/rbac/role.go
@@ -20,8 +20,6 @@ type Role struct {
Name string `json:"name"`
Site []Permission `json:"site"`
// Org is a map of orgid to permissions. We represent orgid as a string.
// TODO: Maybe switch to uuid, but tokens might need to support a "wildcard" org
// which could be a special uuid (like all 0s?)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1072

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
coderd/rbac/role.go
@@ -49,7 +47,6 @@ var (
RoleAuditor = Role{
Name: "auditor",
Site: permissions(map[Object][]Action{
// TODO: @emyrk when audit logs are added, add back a read perm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1074

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
peer/channel.go
// be pooled so synchronously, but is definitely possible.
// REMARK: There's an obvious race-condition here. This is an edge-case, as
// most-frequently data won't be pooled so synchronously, but is
// definitely possible.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1076

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
site/embed.go
@@ -270,8 +270,6 @@ func secureHeaders(next http.Handler) http.Handler {

// Only scripts can manipulate the dom. This prevents someone from
// naming themselves something like '<svg onload="alert(/cross-site-scripting/)" />'.
// TODO: @emyrk we need to make FE changes to enable this. We get 'TrustedHTML' and 'TrustedURL' errors
// that require FE changes to work.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1078

greyscaled
greyscaled commented Apr 19, 2022
View reviewed changes
site/src/pages/templates/[organization]/[template]/index.tsx
// workspaces per-template. This just grabs all workspaces... and then
// later filters them to match the current template.
// This just grabs all workspaces... and then later filters them to match the
// current template.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1082

@greyscaled greyscaled merged commit 5ce0676 into main Apr 19, 2022
@greyscaled greyscaled deleted the vapurrmaid/todos branch April 19, 2022 16:16
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Replace TODO comments with tickets
3 participants
@greyscaled @presleyp @misskniss