Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support bundle: automatically detect DERP disconnects in network support bundle #12166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Feb 15, 2024 · 3 comments
Closed

feat: support bundle: automatically detect DERP disconnects in network support bundle #12166

johnstcn opened this issue Feb 15, 2024 · 3 comments
Assignees
@johnstcn

Comments

@johnstcn
Copy link
Member

johnstcn commented Feb 15, 2024 •
edited
Loading

Part of #12160

Given that we have access to agent logs in coder support bundles, we can now scan the agent logs for potential issues.

Potential strings to scan for and alert on:

  • "disconnected from coderd"
  • "failed to connect to the coordinate endpoint"
  • "failed to close remote coordination"
  • "recv DERPmap error"
  • "speedtest listener failed"
  • "update tailnet addresses"
  • "create tailnet"

NOTE: The above is a sample list; there may be more definitely interesting strings or patterns.
@johnstcn johnstcn mentioned this issue Feb 15, 2024
Closed
8 tasks
@cdr-bot cdr-bot bot added the feature label Feb 15, 2024
@johnstcn
Copy link
Member Author

@spikecurtis @deansheather Would NETGRU have any suggestions here?

@spikecurtis
Copy link
Contributor

To what end?

Like, let's say we scan the logs and find some log lines as above... then what? Rewriting them to a different file in the support bundle seems superfluous, as the person analyzing the support bundle can just grep directly and see the logs in context.

Also, looking at log text is fragile, since we often tweak or change the logs as we modify the code. If there is some specific kind of error we want to care about, we should make it a metric and report it up thru Coderd.

@johnstcn
Copy link
Member Author

johnstcn commented Apr 8, 2024

Thanks Spike. It sounds like this isn't necessarily something we should be doing in the Coder binary. Closing this out for now.

@johnstcn johnstcn closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnstcn @spikecurtis