Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support window resizing for terminal sharing via URLs #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1286
misskniss opened this issue May 3, 2022 · 9 comments
Closed
Tracked by #1286

Support window resizing for terminal sharing via URLs #1276

misskniss opened this issue May 3, 2022 · 9 comments
Labels
api Area: HTTP API

Comments

@misskniss
Copy link

As a user, when I resize a window for a web terminal I want it to format correctly for the new size. (tmux supports this for example.

@misskniss misskniss added the api Area: HTTP API label May 3, 2022
@misskniss misskniss added this to the Community MVP milestone May 3, 2022
@misskniss
Copy link
Author

@tjcran I originally marked this for Community (see the epic associated too). When do we expect customers will want this? Community? Later?

@misskniss
Copy link
Author

Hey team! Please add your planning poker estimate with ZenHub @kylecarbs @deansheather

@tjcran
Copy link

tjcran commented May 5, 2022

@tjcran I originally marked this for Community (see the epic associated too). When do we expect customers will want this? Community? Later?

We are not planning for Terminal Sharing until Enterprise at the earliest. I'm also not clear on why resizing is a blocker for sharing. I'm going to bump this one to Enterprise as well. If it happens earlier, great. But definitely a nice to have for launch.

@deansheather
Copy link
Member

Resizing is a blocker for sharing because having two windows "attached" to the same terminal with different sizes will cause issues right now.

@tjcran
Copy link

tjcran commented May 9, 2022

Resizing is a blocker for sharing because having two windows "attached" to the same terminal with different sizes will cause issues right now.

@deansheather Got it, thanks! Either way, I'm leaving this as "Enterprise MVP" for now, but it will potentially even come after that.

@ammario
Copy link
Member

ammario commented May 23, 2022

@tjcran I think this should be closed and rolled up into the master issue since the terminal would be unusable without smart resizing.

@ketang
Copy link
Contributor

ketang commented May 23, 2022

I'm not convinced this is a blocker. It requires that the user have two windows attached to the same terminal of different sizes. How do they even get into that situation?

@ammario
Copy link
Member

ammario commented May 24, 2022

I'm not convinced this is a blocker. It requires that the user have two windows attached to the same terminal of different sizes. How do they even get into that situation?

It's about the host window not the TTY. The TTY will always be the same size.

@kylecarbs
Copy link
Member

@ketang they could copy + paste the URL for their web terminal, but it's certainly weird and shouldn't be a blocker.

@misskniss misskniss removed this from the Post-MVP milestone Jul 22, 2022
@f0ssel f0ssel closed this as completed Jul 28, 2022
@f0ssel f0ssel closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API
Projects
None yet
Development

No branches or pull requests

7 participants