Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: not uploading arm binaries to [coder-host]/bin #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue May 9, 2022 · 3 comments
Closed

Bug: not uploading arm binaries to [coder-host]/bin #1338

bpmct opened this issue May 9, 2022 · 3 comments
Assignees
@bpmct
Labels
api Area: HTTP API
Milestone
V2 Beta

Comments

@bpmct
Copy link
Member

bpmct commented May 9, 2022 •
edited
Loading

OS Information

  • OS: Debian, armv7
  • coder --version: 
    benpotter@elijo:~/docker-local $ coder --version
Coder v0.5.4-devel+ad8d9dd Fri May  6 20:45:18 UTC 2022
https://github.com/coder/coder/commit/ad8d9dd71a3e3672e78d48058f29bbe5b251bdfb

Steps to Reproduce

  1. Start Coder with coder server or coder server --dev
  2. Navigate to http://coder-access-url]/bin
  3. Notice the lack of ARM binaries

Notes

This is likely the culprit:

coder/.goreleaser.yaml

Lines 29 to 39 in ad8d9dd

- id: coder-slim
dir: cmd/coder
ldflags:
["-s -w -X github.com/coder/coder/buildinfo.tag={{ .Version }}"]
env: [CGO_ENABLED=0]
goos: [darwin, linux, windows]
goarch: [amd64]
hooks:
# The "trimprefix" appends ".exe" on Windows.
post: |
cp {{.Path}} site/out/bin/coder-{{ .Os }}-{{ .Arch }}{{ trimprefix .Name "coder" }}

@bpmct bpmct added the bug 🐛 label May 9, 2022
@bpmct bpmct self-assigned this May 9, 2022
@im-coder-lg
Copy link
Contributor

im-coder-lg commented May 9, 2022 via email

@bpmct
Copy link
Member Author

bpmct commented May 9, 2022

I think this will take a bit of work. We can make a one-line change to goarch to include arm files, but we also need to add start script support for ARM in the go code

@bpmct bpmct mentioned this issue May 10, 2022
Merged
@bpmct
Copy link
Member Author

bpmct commented May 11, 2022

fixed in #1337

@bpmct bpmct closed this as completed May 11, 2022
@misskniss misskniss added this to the V2 Beta milestone May 12, 2022
@misskniss misskniss added the api Area: HTTP API label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpmct bpmct

Labels
api Area: HTTP API
Projects
None yet
Milestone
V2 Beta
Development

No branches or pull requests
3 participants
@misskniss @bpmct @im-coder-lg