Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Error while canceling job should result in failed; instead results in canceled #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #778
, #1939
...
spikecurtis opened this issue May 10, 2022 · 1 comment · Fixed by #3101
Closed
Tracked by #778
, #1939
...

Error while canceling job should result in failed; instead results in canceled #1374

spikecurtis opened this issue May 10, 2022 · 1 comment · Fixed by #3101
Assignees
@Kira-Pilot
Labels
api Area: HTTP API cli Area: CLI
Milestone
Community MVP

Comments

@spikecurtis
Copy link
Contributor

OS Information

  • coder --version: Coder v0.5.4-devel+d847d2b

spotted in code read, c.f.

coder/coderd/provisionerjobs.go

Line 266 in 2df92e6

job.Status = codersdk.ProvisionerJobCanceled

Steps to Reproduce

  1. provisioner_job gets a cancel, this sets canceled_at and status becomes "Cancelling"
  2. provisionerd fails and reports an error on the job, this sets error and completed_at, status becomes "Canceled"

Expected

Status should be Failed

Actual

Status is Canceled

Logs

Screenshot

Notes
@spikecurtis spikecurtis added bug 🐛 api Area: HTTP API labels May 10, 2022
@tjcran
Copy link

tjcran commented May 16, 2022

I agree with this change as important from the experience perspective. I only consider this a nice to have before launch

@tjcran tjcran added this to the Enterprise MVP milestone May 16, 2022
@misskniss misskniss mentioned this issue May 20, 2022
Closed
4 tasks
@tjcran tjcran mentioned this issue Jun 4, 2022
Closed
90 tasks
@tjcran tjcran modified the milestones: Enterprise MVP , Community MVP Jun 4, 2022
@kylecarbs kylecarbs changed the title Bug: error while canceling job should result in failed; instead results in canceled Error while canceling job should result in failed; instead results in canceled Jun 7, 2022
@Kira-Pilot Kira-Pilot self-assigned this Jul 18, 2022
@misskniss misskniss mentioned this issue Jul 19, 2022
Closed
20 tasks
Kira-Pilot added a commit that referenced this issue Jul 20, 2022
@Kira-Pilot
set a failed canceled job status correctly
aafd8e5 
resolves #1374
@Kira-Pilot Kira-Pilot mentioned this issue Jul 20, 2022
Closed
Kira-Pilot added a commit that referenced this issue Jul 21, 2022
@Kira-Pilot
set a failed canceled job status correctly
14009c9 
resolves #1374
Kira-Pilot added a commit that referenced this issue Jul 21, 2022
@Kira-Pilot
set a failed canceled job status correctly
b4f8c53 
resolves #1374
@Kira-Pilot Kira-Pilot mentioned this issue Jul 21, 2022
Merged
Kira-Pilot added a commit that referenced this issue Jul 21, 2022
@Kira-Pilot @johnstcn
fix: set a failed canceled job status correctly (#3101)
0aa8c2e 
* set a failed canceled job status correctly

resolves #1374

* added unit test for convertProvisionerJob

* Update coderd/provisionerjobs_internal_test.go

Co-authored-by: Cian Johnston <[email protected]>

* PR feedback

Co-authored-by: Cian Johnston <[email protected]>
@spikecurtis spikecurtis mentioned this issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
api Area: HTTP API cli Area: CLI
Projects
None yet
Milestone
Community MVP
5 participants
@misskniss @spikecurtis @tjcran @kylecarbs @Kira-Pilot