-
Notifications
You must be signed in to change notification settings - Fork 881
Implement template versions in the CLI #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This feature seems to have multiple requirements, so I am planning to split this into multiple tasks.
Question: Should this list be sorted in reverse chronological order?
Question: Is my understanding for this feature correct? Would this impact other users using the template, or should I be able to update an existing workspace to use a previous version?
Question: In case the list is too long, would we rather implement General question: Do any of these operations need to be access restricted? @ammario @misskniss @tjcran It'll be helpful if we can answer these before starting work on this ticket. |
@AbhineetJain thanks for looking into this. Just to clarify, I think we should only show versions that have workspaces on them so the list is unlikely to become unwieldy for a while. Also, I think we can just delete template versions that don't have active workspaces when workspaces are deleted? On CLI structuring:
It's typically an anti-pattern to have some default operation on the base command and then additional commands. The most obvious issue is that a workspace named Some options:
... and there are other approaches. Note that we use I think we should decompose this issue into the read operations and the update operations. I think there's a lot to consider in the design of the update operations. For example, there is confusion between Another design to consider is Anyways, there's a lot of unknown with the update portion, so I think just focus on good read operations for now. |
As a user, I want to be able to go back in time with my template so I can debug another user's workspace.
As a template admin, I want to be able to view the list of versions in a template and the workspaces on each, so I can:
The text was updated successfully, but these errors were encountered: