Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UI notification 30 minutes before auto-stop #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #275
greyscaled opened this issue May 14, 2022 · 13 comments Β· Fixed by #1825
Closed
Tracked by #275

UI notification 30 minutes before auto-stop #1459

greyscaled opened this issue May 14, 2022 · 13 comments Β· Fixed by #1825
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@greyscaled
Copy link
Contributor

greyscaled commented May 14, 2022

User Story πŸ‘₯

As a user with the dashboard or web terminal open, I'd like to see a clear reminder that my workspace will shutdown soon. I should be reminded 30 minutes before so that I have adequate time to see the message and extend my workspace shutdown, if I'd like to extend it.

I do not want to see system notifications or a pile up of notifications.

I want to see this message even if I get a system notification from being connected via SSH.

@greyscaled greyscaled self-assigned this May 14, 2022
@greyscaled greyscaled added new feature ✨ site Area: frontend dashboard labels May 14, 2022
@greyscaled
Copy link
Contributor Author

greyscaled commented May 14, 2022

Note: we will want "reactive extension" eventually (TBD if in notification or elsewhere), but for starters we need to simply have the notice in place. It's TBD where the notice will show up, but the candidate places are:

  • the workspace card
  • snackbar/toast or some other UI widget
  • system-level notification

The considerations are:

  • the SSH conn uses system-level notifications, and we don't want spam coming from multiple clients
  • the notification needs to be visible in web-based terminals and IDEs, not just the web client itself

From these notes, it seems like pre-emptive extension + notification is sensible in the workspace card, and reactive extension/notification is sensible in the form of a toast/snackbar message.

It's TBD to connect existing toast/snackbar widgets to appear in web-based terminals and IDEs.

@misskniss
Copy link

Hey team! Please add your planning poker estimate with ZenHub @johnstcn @vapurrmaid

@ammario
Copy link
Member

ammario commented May 21, 2022

I suppose this also means that a user must push the TTL at least 30m into the future to avoid a notification spam loop.

@ammario
Copy link
Member

ammario commented May 23, 2022

Also: we have to ensure that multiple open tabs don't send multiple notifications.

@ketang
Copy link
Contributor

ketang commented May 23, 2022

I don't think it's a blocker if multiple open tabs send multiple notifications. Further down the line, I'd say we want multiple open tabs each to notify, but we want them to all go away if one of them is responded to. I expect that state shouldn't be hard to manage on the client. I infer the problem that you want to solve here is users having to dismiss the same popup 10 times.

@ammario
Copy link
Member

ammario commented May 23, 2022

I don't think it's a blocker if multiple open tabs send multiple notifications. Further down the line, I'd say we want multiple open tabs each to notify, but we want them to all go away if one of them is responded to. I expect that state shouldn't be hard to manage on the client. I infer the problem that you want to solve here is users having to dismiss the same popup 10 times.

Yes, exactly. It would be obnoxious to dismiss 10 notification. And I know our customers like to have at least 10 tabs of Coder open at a time.

@greyscaled
Copy link
Contributor Author

greyscaled commented May 26, 2022

Currently, the only way to use v2 is through an SSH connection or a web terminal.

The SSH connection issues a system notification when you're within the reminder window.

We do not want a pile up of notifications also coming from the client. I do not think system notifications coming from both the client and our SSH connection can know about each other or dismiss each other.

Getting 2 notifications is not the end of the world, but also a bit spammy.

As a result, here's what I think we should do for now:

  1. show a notification in the dashboard (so this won't appear on your system tray, but only visible in the dashboard)
  2. show a notification in the terminal application

I feel that this is MVP in the spirit of agile. We can iterate on how or if we want to add a system notification from the web client.

@ammario @johnstcn @ketang - how does this sound to you?

@f0ssel
Copy link
Contributor

f0ssel commented May 26, 2022

I personally like in-window notifs over system notifs on the web app - mainly because I always hit deny on system notifications as a personal preference. System notifs for SSH sounds fine because we don't have another way in from a UX perspective. But if we control the client I'm sure we can do something nicer than system notifs.

@greyscaled
Copy link
Contributor Author

greyscaled commented May 26, 2022

I personally like in-window notifs over system notifs on the web app - mainly because I always hit deny on system notifications as a personal preference. System notifs for SSH sounds fine because we don't have another way in from a UX perspective. But if we control the client I'm sure we can do something nicer than system notifs.

@f0ssel thanks for the input - love this.

As a follow-up, how do you feel about a banner (top) vs a toast (bottom right) vs a toast (top center) ?

@ketang
Copy link
Contributor

ketang commented May 26, 2022

I always hit deny on system notifications as well.

I agree with the MVP attitude. Telling users to have the dashboard open or a shell open doesn't seem onerous.

@johnstcn
Copy link
Member

As a follow-up, how do you feel about a banner (top) vs a toast (bottom right) vs a toast (top center) ?

For a temporary but time-sensitive and important notification, I think a banner is good.

@ammario
Copy link
Member

ammario commented May 26, 2022

I agree with the in-dashboard notification. Also, I think this is one of those cases where any decision is better than no decision, because there are plenty of other more important UX improvement opportunities in the product.

@ketang
Copy link
Contributor

ketang commented May 26, 2022

I think this is one of those cases where any decision is better than no decision

πŸ’―

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants