feat: ui alert <= 30mins from deadline #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.stories.tsx
Outdated
Show resolved
Hide resolved
johnstcn
approved these changes
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.test.tsx
Outdated
Show resolved
Hide resolved
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.test.tsx
Outdated
Show resolved
Hide resolved
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.test.tsx
Outdated
Show resolved
Hide resolved
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.stories.tsx
Outdated
Show resolved
Hide resolved
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
Summary: When a workspace build is <= 30 minutes from auto-scheduled shutdown, then an alert banner is displayed on the workspace page.
d46b2d9 to
f049ae9
Compare
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
kylecarbs
reviewed
May 27, 2022
|
|
||
| export const Language = { | ||
| bannerTitle: "Workspace shutdown", | ||
| bannerDetail: "Your workspace is scheduled to automatically shut down soon.", |
There was a problem hiding this comment.
What do you think about making this the title instead? I feel like the title and detail share roughly the same information, and so maybe we can merge them!
There was a problem hiding this comment.
I'm a-ok with that, will do rn
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
greyscaled
commented
May 27, 2022
site/src/components/WorkspaceScheduleBanner/WorkspaceScheduleBanner.tsx
Outdated
Show resolved
Hide resolved
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Summary: When a workspace build is <= 30 minutes from auto-scheduled shutdown, then an alert banner is displayed on the workspace page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1459
Summary
When a workspace build is <= 30 minutes from auto-scheduled shutdown,
then an alert banner is displayed on the workspace page.
Demo
From Storybook: