Requesting a mutex on this one. I'll assign it to myself as soon as my access is granted, which I will also request shortly.

🔒

Feedback so far:

Simpler formatting updates have been made in #14967, which is under review.

I've looked into how the notifier works so that I can understand how to make more complicated changes. I plan two more change sets.

The first will contain updates to the notification templates where the data that should be added is already part of the notification payload.

The second will deal with notifications for which such additional information is not yet in the payload object. For this final change I will need to look into how to safely add more information to the payload. Because we do not support empty fields in our templates (

I'm also curious about the risk of the Payload struct becoming a kind of god-struct. As it becomes larger over time to support more diverse notifications, it might start to contain information from disparate domains that might be cumbersome to populate in all cases.

cc @mafredri @dannykopping @mtojek

Edit:
Figured out how the payload handles generic data. Updating the templates to use it will be simple enough. I'll try to get the templates updated to use the requested information and then produce updated rendered golden files. After that, I'll find where these specific notifications are enqueued and figure out how to inject the necessary data.

@mafredri Are we happy to close this one? I've merged multiple PRs that address all of these.