Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TemplateWorkspaceManualBuildFailed renders an empty template display name #15065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SasSwart opened this issue Oct 14, 2024 · 1 comment · Fixed by #15067
Closed

TemplateWorkspaceManualBuildFailed renders an empty template display name #15065

SasSwart opened this issue Oct 14, 2024 · 1 comment · Fixed by #15067
Labels
design needed Request for more beauty

Comments

@SasSwart
Copy link
Contributor

SasSwart commented Oct 14, 2024 •
edited by dannykopping
Loading

Re #14967 (comment):

I wondered about this, but didn't want to assume I could overwrite what was specified.
Will update.

@SasSwart @dannykopping Right now the result looks strange. Please take a look below at the notification I received today, it needs more love. I still don't think we need to refer to the display name specifically.

Screenshot 2024-10-12 at 21 18 40

Originally posted by @mtojek in #14967 (comment)
@coder-labeler coder-labeler bot added bug design needed Request for more beauty labels Oct 14, 2024
@SasSwart
Copy link
Contributor Author

SasSwart commented Oct 14, 2024 •
edited
Loading

I still don't think we need to refer to the display name specifically.

Part 0: Update wording to something like:

Hi Bobby,


A manual build of the workspace **boddy-workspace** using the template **bobby's template** failed (version: **0.1**).


The workspace build was initiated by **{{.Labels.initiator}}**.'

Part 1: If the template's display name if available, use it instead of the template's name.

@matifali matifali removed the bug label Oct 14, 2024
@SasSwart SasSwart mentioned this issue Oct 14, 2024
Merged
SasSwart added a commit that referenced this issue Oct 15, 2024
@SasSwart
fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed (
fac77f9 
#15067)

This PR closes #15065.

As advised by @mtojek, a template's display name may be set to "", which
is not useful in an email notification. We'd like to provide a friendly
name for the template, but it also needs to be identifiable.

As such, we fall back to template.Name in the case that the template's
display name is empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design needed Request for more beauty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coderd/notifications): simplify TemplateWorkspaceManualBuildFailed coder/coder
2 participants
@matifali @SasSwart