-
Notifications
You must be signed in to change notification settings - Fork 881
agent connection timings rendering as negative values when agent cannot connect #15432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related issue: https://coder.zendesk.com/agent/tickets/3527 |
@dannykopping instead of returning a golang zero value, would be possible to return null instead? |
Are you asking if it's possible technically, or whether I can make that change? |
Both. If a date is "not defined", as consumer, I would expect it to be null instead of having a "zero value" related to a very specific language. Wdyt? |
I'm pretty swamped with other work so I won't have time to look at this soon, but yes I agree - this should've never sent back a zero value for the date. |
@BrunoQuaresma on the UI side, can we assume that a zero value for this value is effectively null? If those times are golang durations, they're nanoseconds and zero would be impossible as a real value. |
I recently played with workspaces build and in some situations had workspaces struggling to be healthy.
While watching at the build timeline for this workspace - the
connect
step for the agent is displaying a weird value.Looking at the JSON for the endpoint, the
ended_at
field returned seems to be a Golang zero value.An easy way to reproduce is to create or modify an existing template and change the
host
value in theworkspace
- which will result in the agent being impossible to contact.Overall view of the workspace

The text was updated successfully, but these errors were encountered: