Thanks to visit codestin.com
Credit goes to github.com

Skip to content

coder port-forward with IPv6 local address fails parsing #15561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Nov 18, 2024 · 0 comments · Fixed by #15627
Closed

coder port-forward with IPv6 local address fails parsing #15561

spikecurtis opened this issue Nov 18, 2024 · 0 comments · Fixed by #15627
Assignees
@spikecurtis
Labels
networking Area: networking s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@spikecurtis
Copy link
Contributor

coder port-forward supports setting the local address like:

coder port-forward <workspace> --tcp 1.2.3.4:8080:8080

However, our parsing of this is broken for IPv6 addresses, which should be entered like [::1]:8080:8080. This means it's not possible to get a local IPv6 listener on localhost.

Relates to #14529
@spikecurtis spikecurtis added networking Area: networking s2 Broken use cases or features (with a workaround). Only humans may set this. labels Nov 18, 2024
@coder-labeler coder-labeler bot added the bug risk Prone to bugs label Nov 18, 2024
@spikecurtis spikecurtis mentioned this issue Nov 18, 2024
Closed
@spikecurtis spikecurtis self-assigned this Nov 19, 2024
@spikecurtis spikecurtis removed the bug risk Prone to bugs label Nov 22, 2024
@spikecurtis spikecurtis mentioned this issue Nov 22, 2024
Merged
spikecurtis added a commit that referenced this issue Nov 25, 2024
@spikecurtis
fix: fix parsing of IPv6 addresses in coder port-forward (#15627)
648cdd0 
fixes: #15561

Fixes parsing of IPv6 local addresses on `coder port-forward`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
networking Area: networking s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix parsing of IPv6 addresses in coder port-forward coder/coder
1 participant
@spikecurtis