Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Provisionerd should register the running provisioners when it connects #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spikecurtis opened this issue May 19, 2022 · 2 comments
Closed
Assignees
Labels
api Area: HTTP API

Comments

@spikecurtis
Copy link
Contributor

What is your suggestion?

Right now we just hardcode the provisioner types that are registered to a provisionerd in the database, but you can start provisionerd with different sets. In our unit tests, we start only echo, in production we start only terraform. Instead of hardcoding, the provisionerd should send a registration message on connection that says which provisioners it is running.

Why do you want this feature?

This can help us detect config errors where templates are created for provisioner types that aren't supported by the cluster, and can prevent jobs from being sent to provisionerds that cannot run them.

Are there any workarounds to get this functionality today?

Always start all provisioners.

Are you interested in submitting a PR for this?

yes

@misskniss misskniss added the api Area: HTTP API label May 24, 2022
@kylecarbs kylecarbs changed the title Feat: provisionerd should register the running provisioners when it connects Provisionerd should register the running provisioners when it connects Jun 7, 2022
@f0ssel f0ssel closed this as completed Jul 28, 2022
@f0ssel f0ssel reopened this Jul 28, 2022
@kylecarbs
Copy link
Member

@dwahler this might be smart to include as part of #3563 . Thoughts?

@bpmct
Copy link
Member

bpmct commented Oct 25, 2022

going to close as part of #44

@bpmct bpmct closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants