Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Some custom emojis aren't displaying #16263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryan-blunden opened this issue Jan 27, 2025 · 3 comments · Fixed by #16492
Closed

Some custom emojis aren't displaying #16263

ryan-blunden opened this issue Jan 27, 2025 · 3 comments · Fixed by #16492
Assignees
@BrunoQuaresma @mtojek
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@ryan-blunden
Copy link

Version: v2.18.4 6125358

When using the emoji picker, some of the custom emojis aren't displaying.

Emojis.not.displaying.mp4
@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Jan 27, 2025
@matifali
Copy link
Member

Thanks for reporting. I can reproduce on main.

@BrunoQuaresma can you please look into it? Thanks

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 27, 2025
@BrunoQuaresma
Copy link
Collaborator

@matifali sure thing!

@mtojek mtojek self-assigned this Feb 7, 2025
@mtojek
Copy link
Member

mtojek commented Feb 7, 2025

Ok, I have researched this problem a bit and... it is tricky to fix. We can't just override CSS class as the entire emoji picker is behind shadow root. Hence we need to patch the library, which is fairly simple (there is even pending PR).

I tried to fork it here, but was unable to direct coder/site towards that fork. I tried many different ways but as long as this is a monorepo I understand that it may not be so simple.

Let's consider this to be the entry point. Unfortunately running ./script/develop.sh:

error during build:
[commonjs--resolver] Failed to resolve entry for package "emoji-mart". The package may have incorrect main/module/exports specified in its package.json.
    at packageEntryFailure (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:46638:15)
    at resolvePackageEntry (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:46635:3)
    at tryNodeResolve (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:46451:16)
    at Object.resolveId (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:46201:19)
    at file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:20940:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:20840:28)
    at async resolveId (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:19440:26)
    at async ModuleLoader.resolveId (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:19876:15)
    at async Object.resolveId (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/vite/dist/node/chunks/dep-CHZK6zbr.js:12834:10)
    at async PluginDriver.hookFirstAndGetPlugin (file:///Users/mtojek/code/coder/site/node_modules/.pnpm/[email protected]/node_modules/rollup/dist/es/shared/node-entry.js:20840:28)
 ELIFECYCLE  Command failed with exit code 1.

I have also tried ideas like:

pnpm install "git+https://github.com/mtojek/emoji-mart.git#main&path:packages/emoji-mart"

with the same result.

Any clues?

@BrunoQuaresma BrunoQuaresma mentioned this issue Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

@mtojek mtojek

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: display SVG emojis in the picker coder/coder
4 participants
@ryan-blunden @BrunoQuaresma @matifali @mtojek