-
Notifications
You must be signed in to change notification settings - Fork 881
coderd: /bin
compressed binary files do not include Content-Length
#16340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I attempted to reproduce the issue using the following command:
I received the
Are you still able to reproduce the issue on your end? cc @Emyrk |
Yeah, though I only noticed this in the browser, where Firefox is unable to give me download progress, and the header is still missing: It looks to me like curling the file doesn't request a compressed version, as there's no It's the same deal when the VSCode extension downloads a slim dylib from |
@evgeniy-scherbina is focusing on prebuilds for a while so going to unassign for now |
One way of fixing this could be to not use stream compression and instead compress the file completely before sending it (likely with a |
For the Coder Desktop and extensions we can probably just add a header for the normal content length (likely it's own custom header to avoid HTTP libraries thinking it's the body length) and compare against how many bytes we've written to the download file. |
As part of Coder Desktop, we'd like to include the progress of the
.dylib
download (macOS), or the slim binary download (Windows), on the GUI. However, this is currently not possible as the HTTP responses for these files do not include aContent-Length
header.The text was updated successfully, but these errors were encountered: