Windows binaries should contain product version, slim binaries should be signed #16693
Assignees
Comments
This was referenced Feb 25, 2025
deansheather
added a commit
that referenced
this issue
Feb 28, 2025
Adds information like product/file version, description, product name and copyright to compiled Windows binaries in dogfood and release builds. Also adds an icon to the executable. This is necessary for Coder Desktop to be able to check the version on binaries. ### Before:   ### After:    Closes #16693
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Feb 28, 2025
Adds information like product/file version, description, product name and copyright to compiled Windows binaries in dogfood and release builds. Also adds an icon to the executable. This is necessary for Coder Desktop to be able to check the version on binaries. ### Before:   ### After:    Closes #16693
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
Feb 28, 2025
Adds information like product/file version, description, product name and copyright to compiled Windows binaries in dogfood and release builds. Also adds an icon to the executable. This is necessary for Coder Desktop to be able to check the version on binaries. ### Before:   ### After:    Closes #16693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The slim windows binary should be authenticode signed (if it's not already).
The fat and slim binaries on Windows should contain a product version that can be read from the .exe manifest by other apps.
Probably need to use something like this: https://github.com/tc-hib/go-winres
The text was updated successfully, but these errors were encountered: