Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Quiet ESLint so we don't have to import React anymore #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kira-Pilot opened this issue May 27, 2022 · 0 comments · Fixed by #1867
Closed

Quiet ESLint so we don't have to import React anymore #1856

Kira-Pilot opened this issue May 27, 2022 · 0 comments · Fixed by #1867
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@Kira-Pilot
Copy link
Member

We should tweak our ESLint rules so that we don't have to import React at the top of each JSX file.

In version 17, React introduced a new JSX Transform that imports React behind the scenes, so manual import by us devs is no longer required. We should take advantage of this simplification.

AC:

  • tweak our ESLint so we don't hear complaints when we are no longer importing React (details in linked blog)
  • don't worry about import cleanup right now - this can be an incremental effort the whole team can take part in
@Kira-Pilot Kira-Pilot added brainbreak 🧠 site Area: frontend dashboard labels May 27, 2022
@Kira-Pilot Kira-Pilot self-assigned this May 27, 2022
Kira-Pilot added a commit that referenced this issue May 27, 2022
Kira-Pilot added a commit that referenced this issue May 31, 2022
@misskniss misskniss added this to the Community MVP milestone Jun 3, 2022
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants