Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: Workspace Schedule UI: submitting long TTL for workspace in UI caused error to update and workspace to hang and become unusable #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1317
tjcran opened this issue May 30, 2022 · 5 comments · Fixed by #1952
Closed
Tracked by #1317

Bug: Workspace Schedule UI: submitting long TTL for workspace in UI caused error to update and workspace to hang and become unusable #1908

tjcran opened this issue May 30, 2022 · 5 comments · Fixed by #1952
Assignees
@greyscaled
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@tjcran
Copy link

tjcran commented May 30, 2022

  • Browser (if applicable): Chrome, in Windows

Steps to Reproduce

  • Set TTL to 100000000000 (after filling in the other fields with acceptable defaults)
  • Hit submit
  • UI hangs and never updates and becomes unusable

Expected

If the TTL is truly invalid, I should receive an error message preventing the submit and telling me what the values are. Even better if the UI has input validation or at least some help text.

Actual

UI hangs forever

Screenshot

image
@tjcran tjcran added this to the Community MVP milestone May 30, 2022
@ketang
Copy link
Contributor

ketang commented May 30, 2022

Recommendation: if you have a TTL, it cannot be longer than 72 hours. If that's insufficient, and for some reasons they still want a TTL, someone will tell us.

@ammario ammario mentioned this issue May 30, 2022
Closed
@misskniss misskniss added Community MVP 🏁 site Area: frontend dashboard labels May 31, 2022
@greyscaled
Copy link
Contributor

Recommendation: if you have a TTL, it cannot be longer than 72 hours. If that's insufficient, and for some reasons they still want a TTL, someone will tell us.

CC @johnstcn - we can create this constraint

@greyscaled greyscaled mentioned this issue May 31, 2022
Closed
20 tasks
@johnstcn
Copy link
Member

johnstcn commented May 31, 2022 •
edited
Loading

@vapurrmaid FWIW I added some upper bounds in a8ae9b3 -- in this case I set the upper bound to 7 days (184 168 hours).

@greyscaled
Copy link
Contributor

@vapurrmaid FWIW I added some upper bounds in a8ae9b3 -- in this case I set the upper bound to 7 days (184 hours).

Should this ticket make the fix + update that constraint to 72? Or is 184 a sufficient upper bound?

@ketang
Copy link
Contributor

ketang commented May 31, 2022

3 days is no less arbitrary than 7 days (which is 168 hours not 184). What matters is that there's a limit that's not ridiculous.

greyscaled added a commit that referenced this issue May 31, 2022
@greyscaled
fix: missing FE ttl constraint validation
d14051c 
Resolves: #1908
This was referenced Jun 1, 2022
Merged
Closed
greyscaled added a commit that referenced this issue Jun 2, 2022
@greyscaled
fix: missing FE ttl constraint validation (#1952)
ab69c22 
Resolves: #1908
kylecarbs pushed a commit that referenced this issue Jun 10, 2022
@greyscaled @kylecarbs
fix: missing FE ttl constraint validation (#1952)
59966b9 
Resolves: #1908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greyscaled greyscaled

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

fix: missing FE ttl constraint validation coder/coder
6 participants
@ketang @misskniss @johnstcn @tjcran @nadzeyav @greyscaled