fix: use shell-specific command flags on Windows #19800
Open
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the SSH exec path always passed '/c' regardless of shell. When the runner’s shell is PowerShell/pwsh, '/c' is invalid and the command exits 1, producing a flaky failure in WorkspaceSSHExec. Detect the resolved shell and choose the correct caller flag (cmd=/c, powershell/pwsh=-Command, others=-c) so simple commands like 'echo' succeed consistently. Change-Id: I3ed89f9eefe22dfdf3c981d0bc266c0d75d71e08 Signed-off-by: Thomas Kosiewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve shell command execution on Windows by using shell-specific flags
This PR enhances the shell command execution on Windows by selecting the appropriate command flag based on the shell being used:
cmd.exeuses/c-Command-cThis change ensures proper command execution across different shell environments on Windows systems.
Fixes: coder/internal#798