Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use shell-specific command flags on Windows #19800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

fix: use shell-specific command flags on Windows #19800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion agent/agentssh/agentssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,9 +917,23 @@ func (s *Server) CreateCommand(ctx context.Context, script string, env []string,

// OpenSSH executes all commands with the users current shell.
// We replicate that behavior for IDE support.
//
// On Windows, the correct caller flag depends on the shell:
// - cmd.exe -> /c
// - powershell/pwsh -> -Command
// - other shells (e.g. bash.exe from Git Bash) -> -c
caller := "-c"
if runtime.GOOS == "windows" {
caller = "/c"
base := strings.ToLower(filepath.Base(shell))
switch {
case base == "cmd.exe":
caller = "/c"
case strings.Contains(base, "powershell") || base == "pwsh.exe":
caller = "-Command"
default:
// Fall back to POSIX-style -c for shells like bash.exe/sh.exe on Windows
caller = "-c"
}
}
name := shell
args := []string{caller, script}
Expand Down
Loading