Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: Ensure agent websockets from outdated builds are rejected before websocket is opened #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1939
coadler opened this issue Jun 2, 2022 · 2 comments · Fixed by #2002
Closed
Tracked by #1939

Bug: Ensure agent websockets from outdated builds are rejected before websocket is opened #2004

coadler opened this issue Jun 2, 2022 · 2 comments · Fixed by #2002
Assignees
@coadler
Labels
api Area: HTTP API
Milestone
Community MVP

Comments

@coadler
Copy link
Contributor

coadler commented Jun 2, 2022

Exponential backoff is only enabled if the websocket fails to open. If
the websocket is opened but immediately killed, the agent will try to
immediately reconnect. This is desireable in cases where coderd is being
replaced or network conditions cause the connection to die, but not for
permanent errors
@coadler coadler self-assigned this Jun 2, 2022
@coadler coadler linked a pull request Jun 2, 2022 that will close this issue
fix: ensure listen websocket isn't opened for non-latest agents #2002
Merged
@coadler coadler added api Area: HTTP API and removed needs grooming 🪒 labels Jun 2, 2022
@ketang
Copy link
Contributor

ketang commented Jun 2, 2022

Back off should probably be bounded, i.e. once we get to once per 30 seconds or thereabouts, I don't think we should back off more.

@coadler
Copy link
Contributor Author

coadler commented Jun 2, 2022

@ketang it looks like the backoff is currently capped at 10s.

@misskniss misskniss added this to the Community MVP milestone Jun 3, 2022
@misskniss misskniss mentioned this issue Jun 3, 2022
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coadler coadler

Labels
api Area: HTTP API
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

fix: ensure listen websocket isn't opened for non-latest agents coder/coder
3 participants
@ketang @misskniss @coadler