-
Notifications
You must be signed in to change notification settings - Fork 892
After submitting workspace create, give an indication of status/progress #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this needs discussion about whether this is desired (it takes you away from the page with the links you'll use when the build is done) so I'm adding the needs-decision label. |
As a user, I would like to be sent to the workspace page and not to the log one 🤔. What we could do is make the status more explicit, but redirecting to the build log does not look "best" IMO. |
It doesn't have to be the build log page, but it's confusing to me that you initiate an action and are then just...? How about a progress bar or the build log in a modal then? |
Or maybe a tiny build log that just shows the last n lines of the build log in the timeline view (where n is small, like 5). Maybe it's open by default for any still-active jobs and closed for any completed jobs. In both cases it could still take you to the complete log with a click. Maybe also the timeline view should have some "last activity" or something indicating the last time there was output from the job (definitely wandering some from the original idea here). |
Am I correct that if we abstract out the prescriptive approach here that we want: A visual indication in the UI of what is happening with the build for the workspace being created. This may not need to be a full page redirect. We should discuss further. |
Yeah, I think the most important thing is to show things are happening and progressing. The actual view and level of detail are less important as long as they successfully communicate that. |
@ketang @misskniss is this a duplicate of #2020? |
erm... this IS #2020, so... yes and no? |
Sorry, I'm tired! Is this a duplicate of #3025? I'd love to move forward with the designs @BrunoQuaresma proposed in that ticket. |
I don't think it's quite the same. My intention here was not to indicate what the workplace status was but to let the user know that a change to the workspace is happening and progressing. Showing a "Starting" or similar label helps a little bit, but doesn't communicate that progress is being made as opposed to something being stuck or broken. |
IMO what looks best:
Implementation considerations:
|
@BrunoQuaresma wow, thanks for looking at that so quickly! I would be fine with using just an icon without a label given this is a compound button. I can make sure we aria-label appropriately. @ketang What do you think? Would implementation of the above design resolve this ticket? |
I think this will work well for indicating business more visibly. In the happiest world, the state of the progress indicator would be derived from the actual progress of the job, but that's a very first world kind of improvement, and I don't think that level of fanciness is justified right now. @BrunoQuaresma what have you thought about with respect to using color? |
Uh oh!
There was an error while loading. Please reload this page.
Problem Statement
Currently after you initiate build of a workspace, you are taken to the
/workspaces/<uuid>
view. On the former, there's no indication that anything is happening other than a tiny status indicator.Why do you want this feature?
Less effort to see what's going on.
Are there any workarounds to get this functionality today?
Laboriously clicking on the row in the timeline corresponding to my current build.
Definition of Done
Two alternatives (maybe more)- You should instead be taken to the/builds/<uuid>
view.- Some kind of progress or status indicator (that works) to show the user progress is happeningAs per discussion below:

Implement the following design:
AC
The text was updated successfully, but these errors were encountered: