Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test flake: coderd TestUsersFilter #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Jun 28, 2022 · 3 comments
Closed

Test flake: coderd TestUsersFilter #2709

spikecurtis opened this issue Jun 28, 2022 · 3 comments
Assignees
@Emyrk
Labels
api Area: HTTP API

Comments

@spikecurtis
Copy link
Contributor 

=== FAIL: coderd TestUsersFilter (1.24s)
    t.go:81: 2022-06-28 21:43:06.300 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/first
    t.go:81: 2022-06-28 21:43:06.332 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.338 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.356 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.404 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.412 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/b055564d-aecd-4490-ba00-2239338cb62a/roles
    t.go:81: 2022-06-28 21:43:06.416 [DEBUG]	(provisionerd)	<github.com/coder/coder/provisionerd/provisionerd.go:113>	(*Server).connect	connected
    t.go:81: 2022-06-28 21:43:06.437 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.458 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/b055564d-aecd-4490-ba00-2239338cb62a/status/suspend
    t.go:81: 2022-06-28 21:43:06.475 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/b055564d-aecd-4490-ba00-2239338cb62a/profile
    t.go:81: 2022-06-28 21:43:06.498 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.531 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.540 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.554 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.583 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.593 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/8ba46387-99bc-4c49-a0a1-9eaac506dfef/roles
    t.go:81: 2022-06-28 21:43:06.617 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.637 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.668 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.678 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/bfbd9bcc-4ad5-46cd-a632-90365df58289/roles
    t.go:81: 2022-06-28 21:43:06.706 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.729 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.761 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.768 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/a7a4910f-e5e1-426b-a98e-ed217ec58ca8/roles
    t.go:81: 2022-06-28 21:43:06.788 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.807 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/a7a4910f-e5e1-426b-a98e-ed217ec58ca8/status/suspend
    t.go:81: 2022-06-28 21:43:06.833 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.864 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.879 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:06.905 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/9ddb6ba5-8e87-424b-b209-08d1ded116a1/profile
    t.go:81: 2022-06-28 21:43:06.931 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:06.967 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:06.976 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/634a36da-d3cf-45cf-a277-82e311a35410/roles
    t.go:81: 2022-06-28 21:43:07.002 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:07.020 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:07.106 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:07.131 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:07.161 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:07.199 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:07.209 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/8c7490e7-08ce-4e1d-9a9a-700e70a97263/roles
    t.go:81: 2022-06-28 21:43:07.241 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:07.266 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/8c7490e7-08ce-4e1d-9a9a-700e70a97263/status/suspend
    t.go:81: 2022-06-28 21:43:07.328 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    t.go:81: 2022-06-28 21:43:07.388 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users/login
    t.go:81: 2022-06-28 21:43:07.406 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	PUT /api/v2/users/6179977f-ce46-429e-b336-a2abd77c31e4/roles
    t.go:81: 2022-06-28 21:43:07.437 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	GET /api/v2/users/me
    t.go:81: 2022-06-28 21:43:07.456 [DEBUG]	<github.com/coder/coder/coderd/coderd.go:411>	debugLogRequest.func1.1	POST /api/v2/users
    coderdtest.go:275: 
        	Error Trace:	coderdtest.go:275
        	            				users_test.go:619
        	Error:      	Received unexpected error:
        	            	POST http://127.0.0.1:52793/api/v2/users: unexpected status code 409: User already exists.
        	Test:       	TestUsersFilter
    t.go:81: 2022-06-28 21:43:07.472 [DEBUG]	(provisionerd)	<github.com/coder/coder/provisionerd/provisionerd.go:370>	(*Server).closeWithError	closing server with error	{"error": null}

DONE 757 tests, 2 skipped, 1 failure in 72.970s

I suspect this has to do with the fact that we create 15 users with random names, but don't actually check for duplicates, so we could repeat one in a "birthday attack" scenario.
@spikecurtis spikecurtis added bug api Area: HTTP API labels Jun 28, 2022
@Emyrk
Copy link
Member

Emyrk commented Jun 29, 2022

Whooops. I can fix this. My bad

@Emyrk
Copy link
Member

Emyrk commented Jun 29, 2022 •
edited
Loading

Probably exists with other creates too. The random name generator list isn't that big

@Emyrk Emyrk mentioned this issue Jun 29, 2022
Merged
@Emyrk
Copy link
Member

Emyrk commented Jun 29, 2022

#2730

@Emyrk Emyrk self-assigned this Jun 29, 2022
@Emyrk Emyrk closed this as completed Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
api Area: HTTP API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spikecurtis @Emyrk