Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bug: Storybook interaction tests have no CI lane; three stories broken on main #28869

Description

@ThomasK33

The Storybook interaction test project (vitest --project=storybook) has no CI lane: test-js runs --project=unit only, and the CI "Storybook" job runs pixel snapshots (which also fail as PIXEL_KEY environment variable is required on dependabot PRs, so dependabot merges carry a red Storybook check that nobody reads). The interaction suite only runs inside the opt-in local pre-push hook, so story regressions merge silently and then block every developer who has coder.pre-push enabled.

Current breakage on main (68ac2a2), reproduced locally in a full-suite run; my environment reproduces the suite green at 92931dc once #28868's fixes are applied, so these arrived with the latest dependency-bump wave (radix-ui 1.4.3 → 1.6.7, storybook 10.3 → 10.5, et al.):

  • src/components/DateTimeRangePicker/DateTimeRangePicker.stories.tsx > Apply Custom Range
  • src/pages/AISettingsPage/ModelsPage/components/ModelForm.stories.tsx > Leave With Unsaved Changes
  • src/pages/AISettingsPage/ModelsPage/components/ModelForm.stories.tsx > Reasoning Effort In Provider Configuration

(Not yet bisected to a specific bump; not run in isolation. #28868 fixes three other stories broken earlier by the biome 2.5.10 autofix and a collapse refactor, and its PR body has the details on the CI gap.)

Suggested fixes:

  1. Add a CI lane for vitest run --project=storybook so interaction stories gate merges.
  2. Repair or quarantine the three stories above.
  3. Consider making the pixel snapshot step tolerate dependabot PRs (skip instead of fail) so a red "Storybook" check regains meaning.

Generated with mux • Model: anthropic:claude-fable-5 • Thinking: xhigh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions