-
Notifications
You must be signed in to change notification settings - Fork 891
Add a display name to template settings #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Chatted with @kylecarbs a bit, it looks like this was done in order to have consistent validation and pretty URLs across objects. Perhaps a template could have a label |
Spaces I understand for URLs but underscores? Also, we've trimmed down the number of places where we use a name in the URL; is that true of templates as well? Given anticipated future template namespacing, seems like the template name has pros and cons for use in the URL. |
@ketang Yeah I couldn't identify a use for underscores, so not sure why I included it. I'll change the issue title. |
@bpmct I updated the title to say that a display name should exist instead. I still think the slug naming is helpful. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
Looking at this one. |
Hey @bpmct! Could you please confirm the scope of this issue:
Did I miss anything? Should it be possible to change the display name using UI? |
Hey @mtojek. Love this. Will it also use the template display name on other pages, such as the workspace page and workspaces list?
For consistency's sake, I think the display name should be managed just like the icon and description properties (via |
That's the plan and I hope it's doable.
Ok, so it seems that instead of |
Yep! That makes sense :) |
Uh oh!
There was an error while loading. Please reload this page.
Problem statement
I'd love to be able to create templates with the following names:
However, template names are currently being validated as usernames so this is not possible.
coder/codersdk/organizations.go
Line 51 in 3e419dd
coder/coderd/httpapi/httpapi.go
Line 20 in c8d04af
Definition of done
Users can create templates with names that contain spaces.
The text was updated successfully, but these errors were encountered: