Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bug: browser history state is overwritten if user is signed-out while on landing page #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pratheekrebala opened this issue Jan 27, 2023 · 1 comment
Closed

bug: browser history state is overwritten if user is signed-out while on landing page #5898

pratheekrebala opened this issue Jan 27, 2023 · 1 comment
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@pratheekrebala
Copy link

pratheekrebala commented Jan 27, 2023 •
edited
Loading

It looks like the browser history state is being replaced if a user browses to the server when they are not signed in. This prevents a user from using the "back" button on their browser.

coder/site/src/pages/LoginPage/LoginPage.tsx

Lines 16 to 18 in a121201

if (authState.matches("signedIn")) {
return <Navigate to={redirectTo} replace />
} else if (authState.matches("waitingForTheFirstUser")) {

Is this intentional? If not, I think the removing the replace on the navigate component should fix it..

This was initially introduced in: #465
@pratheekrebala pratheekrebala changed the title bug: browser history state is overwritten when user is signed-out bug: browser history state is overwritten if user is signed-out while on landing page Jan 27, 2023
@pratheekrebala pratheekrebala mentioned this issue Feb 9, 2023
Closed
@bpmct bpmct added bug s0 Major regression, all-hands-on-deck to fix s2 Broken use cases or features (with a workaround). Only humans may set this. and removed s0 Major regression, all-hands-on-deck to fix labels Feb 15, 2023
@kylecarbs
Copy link
Member

Not sure I understand... why would the back button need to function if it'd just take the user to /login? Seems like that'd be more of a bug.

Closing for now, but comment the rationale and I'll happily open!

@kylecarbs kylecarbs closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pratheekrebala @kylecarbs @matifali @bpmct